friend declarations in big.h and zzn.h#7
Open
micharu123 wants to merge 1 commit intomiracl:masterfrom
Open
Conversation
…guments without a function definition. So we should forward declare friends in the header.
fabrice102
added a commit
to fabrice102/libscapi
that referenced
this pull request
Jul 21, 2017
Necessary to support macOS.
fabrice102
reviewed
Jul 22, 2017
| #endif | ||
|
|
||
| // Forward Declaration for friend declaration to allow definition in cpp. | ||
| ZZn luc(const ZZn&, const Big&, ZZn* b3=NULL); No newline at end of file |
There was a problem hiding this comment.
This forward declaration should be moved before #endif.
fabrice102
reviewed
Jul 22, 2017
fabrice102
added a commit
to fabrice102/libscapi
that referenced
this pull request
Jul 22, 2017
liorko87
added a commit
to cryptobiu/libscapi
that referenced
this pull request
Jul 30, 2017
Merge pull request miracl/MIRACL#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Friends declared in a header file cannot include default parameter arguments without a function definition. So we should forward declare friends in the header. This change addresses compiler errors due to clang strictness on OS X.