Add recvfrom/sendto to #302 (writev_haesbaert)#303
Open
haesbaert wants to merge 2 commits intomirage:mainfrom
Open
Add recvfrom/sendto to #302 (writev_haesbaert)#303haesbaert wants to merge 2 commits intomirage:mainfrom
haesbaert wants to merge 2 commits intomirage:mainfrom
Conversation
This is useful for direct-style code to avoid copying Cstructs into temporary byte buffers. Signed-off-by: David Scott <dave@recoil.org>
The recv/send tests looked a bit complex so I've changed mine, don't see why we would need threads since it's just one message.
haesbaert
changed the title
Member
|
Thanks! I've committed the suggestions directly into the other PR so perhaps I'll cherry-pick this patch onto the other branch |
Member
|
@djs55 this came up as a blocker for eio-windows in today's eio dev call. Have you had a chance to consolidate this so we can merge/release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds recvfrom and sendto to the existing PR #302 from David.
My github foo is terrible, I don't know how usually this is done, so I checked out and added my commit here.