Skip to content

WIP: Convert the model ipython notebook to a script. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gmodena wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

WIP: Convert the model ipython notebook to a script. #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6887003
Convert the model ipython notebook to a script.
gmodena Sep 8, 2021
5feaaa4
Add nbconvert step to Makefile
gmodena Sep 8, 2021
39c6d12
Add jupyter dep
gmodena Sep 8, 2021
88875a0
Fix artifact path
gmodena Sep 8, 2021
5d3cb29
Add workflow artifact pull request comment
gmodena Sep 8, 2021
314d8cb
Add workflow artifact pull request comment
gmodena Sep 8, 2021
7381fc1
Merge branch 'convert-ipynb-to-py' of github.com:mirrys/ImageMatching…
gmodena Sep 8, 2021
7c00f9d
Fix. workflow file indentation
gmodena Sep 8, 2021
f6f477a
Revert adding comments to a PR
gmodena Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,13 @@ jobs:
export PYTHONPATH=${SPARK_HOME}/python:${SPARK_HOME}/python/lib/py4j-0.10.7-src.zip:${PYTHONPATH}
export PATH=${PATH}:${SPARK_HOME}/bin:${SPARK_HOME}/sbin
make test
- name: Convert notebook to python script
run: |
make py
mkdir -p ima/scripts/
mv algorithm.py ima/scripts
- uses: actions/upload-artifact@v2
with:
name: algorithm
path: ima/scripts/algorithm.py

5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ spark_version := 2.4.8
hadoop_version := 2.7
spark_home := spark-${spark_version}-bin-hadoop${hadoop_version}
spark_tgz_url := https://downloads.apache.org/spark/spark-${spark_version}/${spark_home}.tgz
ima_notebook := algorithm.ipynb

venv: requirements.txt
test -d venv || python3 -m venv venv
Expand All @@ -21,3 +22,7 @@ flake8: venv

test: venv
. venv/bin/activate; PYTHONPATH=${PYTHONPATH}:etl/ pytest --cov etl tests/

py: venv
# nbconvert output is saved as <basename>.py
. venv/bin/activate; jupyter nbconvert ${ima_notebook} --to script
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ pytest==6.2.2
pytest-spark==0.6.0
pytest-cov==2.10.1
flake8==3.8.4
jupyter==1.0.0