Skip to content

[ADD] onScrollListener callback #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OmranElmasry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ADD] onScrollListener callback #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/ScrollViewIndicator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export default ({
scrollIndicatorStyle = {},
...props
}) => {
const { onScroll, ...propsToSpread } = props;
const [fadeAnim] = useState(
new Animated.Value(shouldIndicatorHide ? 0 : 1),
);
Expand All @@ -33,14 +32,7 @@ export default ({
setScrollIndicatorContainerHeight,
] = useState(1);

const handleScroll = (value) => {
const {nativeEvent: { contentOffset }} = value;
/**
* Propagating onScroll event upwards in case onScroll prop is provided
*/
if (onScroll && typeof onScroll === 'function') {
onScroll(value);
}
const handleScroll = ({ contentOffset }) => {
//Calculation scroll indicator position based on child height and scrollView view height)
const movePercent =
contentOffset.y /
Expand Down Expand Up @@ -99,12 +91,15 @@ export default ({
onLayout={e =>
setVisibleScrollPartHeight(e.nativeEvent.layout.height)
}
onScroll={handleScroll}
onScroll={(e) => {
props.onScrollListener(e)
handleScroll(e.nativeEvent)
}}
scrollEventThrottle={16}
onMomentumScrollEnd={() => runHideTimer()}
onScrollBeginDrag={() => showIndicator()}
showsVerticalScrollIndicator={false}
{...propsToSpread}
{...props}
>
{children}
</ScrollView>
Expand Down