Fix Speakeasy targets in GitHub actions #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated SDKError now requires a raw_response, which we don't have in the init or hook.
jean-malo
approved these changes
Jan 9, 2026
dumontg
commented
Jan 12, 2026
| if access_token: | ||
| return access_token | ||
|
|
||
| assert credentials is not None, "credentials must be initialized" |
Contributor
Author
There was a problem hiding this comment.
Should normally never assert because of the logic above. That's why I used an assert
GaspardBT
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI for GCP and Azure SDKs:
packages/mistralai_gcp/src/mistralai_private_gcp/sdk.py(not tracked by Speakeasy since we added gcloud authentication)SDKErrorfor non-HTTP errors (it now expects araw_responsein its constructor and internally makes accesses to its attributes). They have been replaced withValueErrorwhen relevant (aligned with elsewhere in the SDK for invalid inputs) or basicExceptions.