Skip to content

fix: add fixes to copilot review

d375580
Select commit
Loading
Failed to load commit list.
Merged

feat/discord-integration #30

fix: add fixes to copilot review
d375580
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Dec 10, 2025 in 28s

Annotations

Check warning on line 89 in apps/api/src/discord/buttons/orchestrator.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this array "reverse" operation to a separate statement or replace it with "toReversed".

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsFk4MhnByX-KFmYUIe&open=AZsFk4MhnByX-KFmYUIe&pullRequest=30

Check failure on line 97 in apps/api/src/domain/clients/discord/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `return value` over `return Promise.resolve(value)`.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsA7FaRCopQsWEDjcg-&open=AZsA7FaRCopQsWEDjcg-&pullRequest=30

Check warning on line 80 in apps/api/src/discord/bot.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this array "reverse" operation to a separate statement or replace it with "toReversed".

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsFk4JXnByX-KFmYUId&open=AZsFk4JXnByX-KFmYUId&pullRequest=30

Check failure on line 56 in apps/api/src/discord/bot.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsFk4JXnByX-KFmYUIc&open=AZsFk4JXnByX-KFmYUIc&pullRequest=30

Check warning on line 77 in apps/api/src/discord/commands/orchestrator.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this array "reverse" operation to a separate statement or replace it with "toReversed".

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsFk4M4nByX-KFmYUIf&open=AZsFk4M4nByX-KFmYUIf&pullRequest=30

Check warning on line 19 in apps/api/src/domain/clients/discord/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'client' is never reassigned; mark it as `readonly`.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsA7FaRCopQsWEDjcg8&open=AZsA7FaRCopQsWEDjcg8&pullRequest=30

Check warning on line 20 in apps/api/src/domain/clients/discord/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'rest' is never reassigned; mark it as `readonly`.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsA7FaRCopQsWEDjcg9&open=AZsA7FaRCopQsWEDjcg9&pullRequest=30

Check warning on line 66 in apps/web/src/sections/account_details/discord/index.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsA7Fd0CopQsWEDjchC&open=AZsA7Fd0CopQsWEDjchC&pullRequest=30

Check warning on line 106 in apps/api/src/domain/clients/discord/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsA7FaRCopQsWEDjcg_&open=AZsA7FaRCopQsWEDjcg_&pullRequest=30

Check warning on line 167 in apps/api/src/domain/clients/discord/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsA7FaRCopQsWEDjchB&open=AZsA7FaRCopQsWEDjchB&pullRequest=30

Check warning on line 108 in apps/api/src/domain/clients/discord/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression.

See more on https://sonarcloud.io/project/issues?id=mitgdev_mitg.forge&issues=AZsA7FaRCopQsWEDjchA&open=AZsA7FaRCopQsWEDjchA&pullRequest=30