Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontends/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"version": "0.0.0",
"devDependencies": {
"@faker-js/faker": "^10.0.0",
"@next/eslint-plugin-next": "^14.2.7",
"@next/eslint-plugin-next": "^16.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The upgrade to @next/eslint-plugin-next v16 requires a new "flat config" format, but the project still uses the legacy .eslintrc.js, which will cause the CI linting step to fail.
Severity: CRITICAL

Suggested Fix

Migrate the ESLint configuration from the legacy .eslintrc.js file to the new flat config format by creating an eslint.config.js or eslint.config.mjs file. This will align the project with the requirements of @next/eslint-plugin-next v16 and ensure the linting process runs correctly.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontends/package.json#L38

Potential issue: The project upgrades `@next/eslint-plugin-next` to v16, which is
designed for ESLint's new "flat config" format (`eslint.config.js`). However, the
repository's configuration remains in the legacy `.eslintrc.js` format. This
incompatibility will cause the `yarn lint-check` command, executed during the CI "Lints"
step, to fail with a configuration error. The linter will be unable to correctly load
the Next.js plugin preset, breaking the CI pipeline.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading @next/eslint-plugin-next to v16 is incompatible with the project's legacy .eslintrc.js configuration, which will cause the lint-check command to fail in CI.
Severity: HIGH

Suggested Fix

To resolve this, either migrate the ESLint configuration from the legacy .eslintrc.js to the new eslint.config.js (flat config) format as recommended by Next.js v16, or avoid upgrading @next/eslint-plugin-next until the configuration migration is complete.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontends/package.json#L38

Potential issue: The project's `frontends/package.json` is being updated to use
`@next/eslint-plugin-next` version 16. This new version of the plugin is designed for
ESLint's new "flat config" format and is not backward compatible with the legacy
`.eslintrc.js` file used in the project. When the `yarn lint-check` command runs in CI,
ESLint (version 8.57.1) will attempt to load the shareable config
`"plugin:@next/next/recommended"`. However, the v16 plugin likely no longer exports this
in the expected legacy format, which will cause a runtime error during the linting
process and fail the CI build.

"@swc/core": "^1.11.29",
"@swc/jest": "^0.2.38",
"@testing-library/jest-dom": "^6.4.8",
Expand Down
45 changes: 4 additions & 41 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading