Skip to content

Release 0.56.6#3014

Merged
odlbot merged 3 commits intoreleasefrom
release-candidate
Mar 5, 2026
Merged

Release 0.56.6#3014
odlbot merged 3 commits intoreleasefrom
release-candidate

Conversation

@odlbot
Copy link
Contributor

@odlbot odlbot commented Mar 4, 2026

Anastasia Beglova

# A follow up pr will update the next line and populate
# the new resource_category field.
"resource_type_group": FilterConfig("resource_category"),
"resource_type_group": FilterConfig("resource_type_group"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Removing the resource_category fallback field before a full re-index completes will cause searches filtering by resource_type_group to return incomplete results.
Severity: HIGH

Suggested Fix

Ensure that a full re-index of the search data is completed and the new index is live before deploying this code change. This will guarantee all documents have the resource_type_group field, preventing incomplete search results. Alternatively, delay the removal of the resource_category fallback logic until the re-index is confirmed to be finished in production.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: learning_resources_search/constants.py#L99

Potential issue: The code removes a temporary workaround that duplicated
`resource_type_group` data into the `resource_category` field. If this change is
deployed before a full OpenSearch re-index is completed, existing documents will not
have the `resource_type_group` field. When a user filters by `resource_type_group`, the
term query will not match these older documents, leading to silently incomplete search
results. This is a deployment-dependent issue; the bug manifests if the deployment
precedes the completion of the data migration.

Did we get this right? 👍 / 👎 to inform future reviews.

@odlbot odlbot merged commit 9b9138f into release Mar 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants