Skip to content

Increase page size to 30 for contract programs #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkachel merged 2 commits into from
Mar 11, 2026
+15 −1
Merged

Increase page size to 30 for contract programs #3036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff0ada2
Add page_size to program list query when pulling programs for contrac…
jkachel Mar 10, 2026
671ae9c
Add page size where we're generating a list of page IDs
jkachel Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions frontends/main/src/app-pages/DashboardPage/ContractContent.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ describe("ContractContent", () => {
urls.programs.programsList({
org_id: orgX.id,
contract_id: contract.id,
page_size: 30,
}),
{
results: [programA, programB],
Expand Down Expand Up @@ -288,6 +289,7 @@ describe("ContractContent", () => {
urls.programs.programsList({
id: programIds,
contract_id: orgX.contracts[0].id,
page_size: programIds.length,
}),
{ results: [programB, programA] }, // Return in same order as requested
)
Expand Down Expand Up @@ -366,6 +368,7 @@ describe("ContractContent", () => {
urls.programs.programsList({
id: programIds,
contract_id: orgX.contracts[0].id,
page_size: programIds.length,
}),
{ results: [programA, programB] }, // API returns A first
)
Expand Down Expand Up @@ -428,6 +431,7 @@ describe("ContractContent", () => {
urls.programs.programsList({
id: [programA.id],
contract_id: orgX.contracts[0].id,
page_size: 1,
}),
{ results: [programA] },
)
Expand Down Expand Up @@ -491,6 +495,7 @@ describe("ContractContent", () => {
urls.programs.programsList({
id: programIds,
contract_id: orgX.contracts[0].id,
page_size: programIds.length,
}),
{ results: [programB, programA] },
)
Expand Down Expand Up @@ -644,6 +649,7 @@ describe("ContractContent", () => {
urls.programs.programsList({
id: programIds,
contract_id: orgX.contracts[0].id,
page_size: programIds.length,
}),
{ results: [programANoCourses, programB] },
)
Expand Down Expand Up @@ -709,6 +715,7 @@ describe("ContractContent", () => {
urls.programs.programsList({
org_id: orgX.id,
contract_id: orgX.contracts[0].id,
page_size: 30,
}),
{
results: [programWithCertificate],
Expand Down
7 changes: 6 additions & 1 deletion frontends/main/src/app-pages/DashboardPage/ContractContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ const useProgramCollectionCourses = (
...programsQueries.programsList({
id: programIds,
contract_id: contractId,
page_size: programIds.length,
}),
enabled: programIds.length > 0,
})
Expand Down Expand Up @@ -465,7 +466,11 @@ const ContractContentInternal: React.FC<ContractContentInternalProps> = ({
enrollmentQueries.programEnrollmentsList(),
)
const programsQuery = useQuery(
programsQueries.programsList({ org_id: orgId, contract_id: contract.id }),
programsQueries.programsList({
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is elsewhere in this file...

  const programsQuery = useQuery({
    ...programsQueries.programsList({
      id: programIds,
      contract_id: contractId,
    }),
    enabled: programIds.length > 0,
  })

which I think fetches the programs belonging to a program collections.

I guess that could exceed 12, too. I tend to do page_size: programIds.length in this scenario.

org_id: orgId,
contract_id: contract.id,
page_size: 30,
}),
)
const programCollectionsQuery = useQuery(
programCollectionQueries.programCollectionsList({}),
Expand Down
2 changes: 2 additions & 0 deletions frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ const setupProgramsAndCourses = () => {
urls.programs.programsList({
org_id: orgX.id,
contract_id: contract.id,
page_size: 30,
}),
{
results: [programA, programB],
Expand Down Expand Up @@ -314,6 +315,7 @@ function setupOrgDashboardMocks(
mitxonline.urls.programs.programsList({
org_id: org.id,
contract_id: contracts[0].id,
page_size: 30,
}),
{ results: programs },
)
Expand Down
Loading