feat: move async-storage to peerDependencies #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move @react-native-async-storage/async-storage from dependencies to peerDependencies to resolve duplicate native module conflicts with Expo 52+ which requires async-storage v2.x while the SDK was pinning v1.x. Changes: - Move async-storage to peerDependencies (^1.15.0 || ^2.0.0) - Mark as optional via peerDependenciesMeta - Add to devDependencies for testing - Update error message with clearer installation instructions - Update README with AsyncStorage installation step - Update MixpanelExpo sample to explicitly install async-storage - Add CHANGELOG entry for v3.2.0 Fixes #323
There was a problem hiding this comment.
Pull request overview
This PR resolves duplicate native module conflicts with Expo 52+ by moving @react-native-async-storage/async-storage from dependencies to peerDependencies. The change supports both v1.x and v2.x versions via the range ^1.15.0 || ^2.0.0, and marks the dependency as optional with automatic fallback to in-memory storage.
Changes:
- Moved async-storage from dependencies to peerDependencies (optional) in package.json
- Updated error messages with clearer instructions and warnings about data persistence
- Updated README with AsyncStorage installation step
- Updated MixpanelExpo sample app to explicitly install async-storage v2.x
- Added CHANGELOG entry documenting the breaking change
Reviewed changes
Copilot reviewed 22 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Moves async-storage to peerDependencies (optional), adds to devDependencies for testing |
| package-lock.json | Updates lockfile reflecting dependency structure changes and version bumps |
| javascript/mixpanel-storage.js | Improves error messages with version requirements and persistence warnings |
| Samples/MixpanelExpo/package.json | Explicitly installs async-storage v2.x |
| Samples/MixpanelExpo/yarn.lock | Updates yarn lockfile for async-storage v2.x |
| Samples/MixpanelExpo/ios/* | Generated iOS project files for Expo sample app |
| README.md | Documents AsyncStorage installation step and peer dependency change |
| CHANGELOG.md | Documents breaking change and migration instructions |
Files not reviewed (1)
- Samples/MixpanelExpo/ios/MixpanelExpo.xcworkspace/contents.xcworkspacedata: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@react-native-async-storage/async-storagefromdependenciestopeerDependenciesto resolve duplicate native module conflicts^1.15.0 || ^2.0.0peerDependenciesMeta- SDK falls back to in-memory storage if unavailableContext
Expo 52+ requires
@react-native-async-storage/async-storagev2.x, whilemixpanel-react-nativewas pinning v1.x as a direct dependency. This causedexpo-doctorto flag duplicate native module dependencies, which can lead to unexpected build errors.Moving async-storage to peerDependencies allows consuming projects to use their preferred version (v1.x or v2.x), eliminating the conflict.
Breaking Change
Action Required: If your project doesn't already include async-storage, run:
Most Expo projects already include this package, so no additional installation is needed.
Test plan
npm pack --dry-runexcludes async-storage from dependenciesFixes #323
Related: #327