Fix import to use a block to configure the http post#109
Open
jshow wants to merge 1 commit intomixpanel:masterfrom
Open
Fix import to use a block to configure the http post#109jshow wants to merge 1 commit intomixpanel:masterfrom
jshow wants to merge 1 commit intomixpanel:masterfrom
Conversation
Contributor
|
Hi @jshow, thanks for opening this PR. We can't respond immediately but we'll get back to you after we investigate. |
|
@andrewpurcell that's quite a long investigation you conduct, guys. Really long for a paid service. |
|
@andrewpurcell any change to have a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion, no tests written as yet - the branch is working for my purposes presently
Background
Import is broken. #106
The MixPanel import api requires the API SECRET to be passed in basic authentication
This PR adds a configuration block to the HTTP Post object, so basic_auth can be configured through a block
in host app
config/initializers/mixpanel.rb