Use Array#max for BufferedConsumer @max_length#118
Open
shayonj wants to merge 1 commit intomixpanel:masterfrom
Open
Use Array#max for BufferedConsumer @max_length#118shayonj wants to merge 1 commit intomixpanel:masterfrom
shayonj wants to merge 1 commit intomixpanel:masterfrom
Conversation
By using using min, we would always get the default MAX_LENGTH, which is 50 if we would want to process more items in buffer. This fix now uses .max, to also align with the variable and constant naming intentions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using
min, we would always get the defaultMAX_LENGTH, which is50if we would want to process more items in buffer. This fix now uses
.max, to alsoalign with the variable and constant naming intentions