Fix inconsistent timestamp format in groups_spec.rb test expectations#128
Merged
hans-lizihan merged 2 commits intohans-fix-ghafrom Dec 9, 2025
Merged
Fix inconsistent timestamp format in groups_spec.rb test expectations#128hans-lizihan merged 2 commits intohans-fix-ghafrom
hans-lizihan merged 2 commits intohans-fix-ghafrom
Conversation
Changed 9 occurrences from `@time_now.to_i * 1000` to `(@time_now.to_f * 1000).to_i` to ensure consistent millisecond precision across all test expectations. Co-authored-by: hans-lizihan <7879022+hans-lizihan@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP address feedback from PR #127
Fix inconsistent timestamp format in groups_spec.rb test expectations
Dec 9, 2025
hans-lizihan
approved these changes
Dec 9, 2025
hans-lizihan
added a commit
that referenced
this pull request
Dec 9, 2025
* Fixed gha * Fixed tests and millisecond bugs * Fixed tests and millisecond bugs * Updated * Updated matrix * support up to 3.3 * Support 3.4 * Remove 2.2 * Update mixpanel-ruby.gemspec Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update lib/mixpanel-ruby/groups.rb Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix inconsistent timestamp format in groups_spec.rb test expectations (#128) * Initial plan * Fix inconsistent timestamp format in groups_spec.rb tests Changed 9 occurrences from `@time_now.to_i * 1000` to `(@time_now.to_f * 1000).to_i` to ensure consistent millisecond precision across all test expectations. Co-authored-by: hans-lizihan <7879022+hans-lizihan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: hans-lizihan <7879022+hans-lizihan@users.noreply.github.com> * Fixed --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: hans-lizihan <7879022+hans-lizihan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test expectations in
groups_spec.rbused inconsistent timestamp conversion formats, mixing(@time_now.to_f * 1000).to_i(millisecond-preserving) with@time_now.to_i * 1000(millisecond-truncating).Changes
(@time_now.to_f * 1000).to_iproperly cast dates,convert offset datetimes to UTC,convert offset ActiveSupport::TimeWithZone,set_once,remove,union,unset(both variants), anddelete_group💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.