Skip to content

Remove excessive logging from label-reachable.h#1

Open
shiralal wants to merge 1 commit intomjansche:masterfrom
shiralal:excessive_logs_issue
Open

Remove excessive logging from label-reachable.h#1
shiralal wants to merge 1 commit intomjansche:masterfrom
shiralal:excessive_logs_issue

Conversation

@shiralal
Copy link

No description provided.

@shiralal shiralal force-pushed the excessive_logs_issue branch from 8b591de to c391c9f Compare October 10, 2024 11:59
@mjansche
Copy link
Owner

Thanks for your pull request! This repo is an unofficial mirror of OpenFST, and as such it itsn't the right place to incorporate changes. Changes here would not necessarily be reflected upstream, plus this mirror would diverge from the upstream sources. That said, I will reach out to the right people who can perhaps try to see if they would like to incorporate this change upstream.

I will leave this PR open for now, for better visibility.

@agutkin
Copy link

agutkin commented Oct 11, 2024

Running with verbosity level of 3 already provides excessive amount of diagnostics, so my question would be why run with in such a verbose mode anyway? If running in VLOG(3) mode is necessary (diagnostics is absolutely required), then I suppose one option would be to use VLOG(4) or VLOG(5) here, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants