OpenFX Module #1186

joinlaw · 2025-12-16T12:18:35Z

continuation on the close PR #1051 on this version unsupported plugins such as draw suite and opengl plugins are filter out so they don't appear on the plugins (filters) list.

Some plugins such as com.genarts:OpenGLSamplePlugin and net.sf.openfx.Shadertoy doesn't return kOfxStatErrMissingHostFeature status in kOfxActionDescribe and kOfxImageEffectActionDescribeInContext OpenFX mainEntry action but they are harmless when they run because they have no effect when mentioned suits are not available.

Some plugins such as com.genarts:OpenGLSamplePlugin contain colons : in the pluginIdentifier which I replace with ^ (openfx.com.genarts^OpenGLSamplePlugin) to avoid any issue with MLT filters naming constraints.

joinlaw · 2025-12-16T12:19:07Z

@luzpaz

luzpaz · 2025-12-19T18:27:05Z

@joinlaw any chance you can show the feature in action ? (like a screencast?)

joinlaw · 2025-12-20T05:33:56Z

@luzpaz

demos

basic-gain-plugin.webm

ddennedy · 2025-12-20T19:29:38Z

Thank you, I can start taking a look around middle of January. I am taking a break over the holiday before some release activities at the end of the year, which is often followed by increased support.

src/modules/openfx/CMakeLists.txt

src/modules/openfx/factory.c

ddennedy · 2025-12-20T20:07:27Z

src/modules/openfx/filter_openfx.c

+    mlt_properties params = mlt_properties_get_data(image_effect, "mltofx_params", NULL);
+    mlt_properties image_effect_params = mlt_properties_get_data(image_effect, "params", NULL);
+
+    *format = mlt_image_rgba;


I am not going to accept any new code that is 8-bit only. I see OpenFX has kOfxBitDepthShort that appears to correspond to the mlt_image_rgba64 that we added in 2025. Please try to include it.

src/modules/openfx/filter_openfx.yml

src/modules/openfx/ofxDialog.h

ddennedy · 2025-12-20T20:31:00Z

src/modules/openfx/mlt_openfx.c

+    /* TODO: add support for OpenGL plugins */
+    propSetString(host_properties, kOfxImageEffectPropOpenGLRenderSupported, 0, "false");


We might not ever be able to support for OpenGL (or CUDA or Metal) without a good way to prevent multiple heavy data transfers between CPU and GPU RAM. For example, the Movit module and proper management by the app such as Shotcut addresses that.

No code change requested here. Just FYI to inform any future plans. I guess the key point is that OpenGL integration should not be standalone and needs to coordinate with the movit module. Also, the qglsl consumer is a way for melt to provide an OpenGL context on the render thread. Also, the future of OpenGL is also rather uncertain. The GPU tech landscape is messy.

src/modules/openfx/filter_openfx.c

izakikoparadox · 2025-12-21T00:47:10Z

I was literally just searching the progress for OFX support and I'm pleasantly surprised to see effort being made within hours ago. I guess the big question is, Is there a supposed date when I'd finally be able to use OFX plugins in kdenlive?

bmatherly · 2025-12-31T16:40:13Z

@joinlaw I am interested in helping to sponsor this change into the code base. I intend to fetch your branch and start testing. Do you have any work-in-progress that I should have? Also, do you want any help resolving the comments above? Let me know how i can help.

joinlaw · 2025-12-31T20:21:31Z

@joinlaw I am interested in helping to sponsor this change into the code base. I intend to fetch your branch and start testing. Do you have any work-in-progress that I should have? Also, do you want any help resolving the comments above? Let me know how i can help.

Well after this first merge request get merged the main priority is to implement OpenFX OpenGL plugins suite and DrawSuite (openfx extension something like postscript or cairo vector graphics).

Once I have free time I will resolve all comments by @ddennedy and hopefully we will have basic OpenFX support so we can implement all other openfx extensions later.

bmatherly · 2026-01-01T20:07:55Z

src/modules/openfx/ofxDialog.h

@@ -0,0 +1,72 @@
+


We do not want to duplicate the OFX host header files in our source tree. Today, when installing the OFX host environment for myself, I was surprised to find that they do not offer an install target for the host files. HOWEVER, they do offer pre-packaged development files with each release:
https://github.com/AcademySoftwareFoundation/openfx/actions/runs/19546967037
The directory structure of that package is documented in their github workflow:
https://github.com/AcademySoftwareFoundation/openfx/blob/main/.github/workflows/build.yml#L364
We should remove all these header files, and require the packager to have the official package from OFX installed - or to provide their own if they build it themselves. This will allow us to support compilation with different versions of the OFX framework over time.

As a convenience, we could offer a script for the packager to download and extract the official packages. That is not a requirement from me - just a suggestion.

and possibly using a git submodule

MLT would still need libOfxHost.a and libOfxSupport.a. Where would they get those from? And how would we guarantee that the tag/release that we chose to get with git submodule matches the library versions the packager has?

I am open minded, but i do not want to build OFX as part of building this OFX MLT module because then our build would depend on conan - which is completely unnecessary if the packager just uses the official package release from OFX.

libOfxSupport.a is utility library to be used by plugin developers and as you see it is statically linked by the developers.

libOfxHost.a is sample/example reference implementation C++ library classes and my code is free from it because openfx module is pure C not C++.

The only thing needed is the header files at this folder only https://github.com/AcademySoftwareFoundation/openfx/tree/main/include so we don't need conan.

ddennedy · 2026-01-02T06:18:39Z

Please turn off this new module in .github/workflows/build-windows-msvc.yml for now. There is still a lot work to do to get modules, in general, to build with MSVC.

… ends with other postfix

…ths from environment variable

…d widget '2dsize'

… implementation

- handle the Microsoft Visual C++ compiler in module CMakeLists.txt - Change every copyright to the year 2025 - Use C99 variables in the for loop initializer declare style - Clang format and include <stdbool.h> explicitly - specify which versions of OpenFX supported - mention OpenFX header files URL in mlt_openfx.c - using mlt_image and its functions in src/modules/openfx/filter_openfx.c

…sts.txt

bmatherly · 2026-01-03T21:05:38Z

@joinlaw, can you provide more commentary about how we can help potential users get access to openfx plugins?

For example, I see you are using G'MIC plugins in your working copy. I have seen previous requests for that. So, I think in order to provide that, I will need:

G'MIC library
One or possibly more OFX plugins that adapt G'MIC to openfx. I see a couple projects out there
- https://github.com/NatronGitHub/openfx-gmic
- https://github.com/MrKepzie/openfx-gmic

I haven't found binary releases on the GitHub pages. And my Unbuntu package manger does not seem to provide the OFX files (it does provide the G'MIC library).

Where will users get the OFX files from to use with this module? Will KDENLIVE help users download them?

joinlaw · 2026-01-03T21:37:49Z

@joinlaw, can you provide more commentary about how we can help potential users get access to openfx plugins?

For example, I see you are using G'MIC plugins in your working copy. I have seen previous requests for that. So, I think in order to provide that, I will need:
* G'MIC library

* One or possibly more OFX plugins that adapt G'MIC to openfx. I see a couple projects out there
  
  * https://github.com/NatronGitHub/openfx-gmic
  * https://github.com/MrKepzie/openfx-gmic
I haven't found binary releases on the GitHub pages. And my Unbuntu package manger does not seem to provide the OFX files (it does provide the G'MIC library).

Where will users get the OFX files from to use with this module? Will KDENLIVE help users download them?

Actually I downloaded the Natron portable package and used them also I built the example plugins nothing more than that but I have seen before few other free software plugins over the internet.

I added them to the environment variable

export OFX_PLUGIN_PATH=/path/to/openfx/examples/destdir:/path/to/Natron-2.5.0-Linux-x86_64-no-installer/Plugins/OFX/Natron

ddennedy · 2026-01-03T22:05:45Z

There are a lot of OpenFX plugins, many of them commercial. Besides web search there are a lot of other so-called organic means to learn about them such as special interest web sites and forums. It is a lot like the VST plugin ecosystem. Expect to potentially deal with a lot of support and troubleshoot with the diversity. Properly supporting and debugging them in host may also cost money if you want to actually provide assistance.

luzpaz mentioned this pull request Dec 20, 2025

Draft: Initial work on OpenFX module support #1051

Closed

ddennedy requested changes Dec 20, 2025

View reviewed changes

joinlaw force-pushed the openfx branch 2 times, most recently from 1d7cfb4 to d3cad6a Compare December 31, 2025 23:30

bmatherly requested changes Jan 1, 2026

View reviewed changes

mr.fantastic added 17 commits January 2, 2026 15:22

Initial work on OpenFX module support

a3bc9ee

Making yml files explicit in openfx module CMakeLists

d333153

clang-format openfx module source files

fc11db1

OpenFX module: adding TODO to incompleted code

cb95d96

reordering functions in src/modules/openfx/mlt_openfx.c|h

cbe0845

openfx module: avoid reading directories that contain .ofx.bundle but…

f0703be

… ends with other postfix

openfx module: using typedefs for shared object symbols

010e222

openfx module: replace strtok with strtok_r to parse openfx plugin pa…

0cf05a8

…ths from environment variable

closedir after parsing openfx plugins

7984995

openfx module support more parameters types

308dfdd

openfx module fix plugin parameter not passed correctly form the host

a1c0c9c

openfx module adding support for color parameters

4818f07

openfx module: add support for double 2d point

7ff6e07

filter_openfx.c set default value for parameter with type 'double' an…

9698a58

…d widget '2dsize'

openfx module: progress on kOfxImageEffectActionGetRegionOfDefinition…

6269faf

… implementation

openfx module: avoid adding unsupported plugins as filters

3b7cc14

Fix openfx module build issue with mingw/msys2

73fa29c

mr.fantastic added 3 commits January 2, 2026 15:22

Make sure that OpenFX module have the imported target glib in CMakeLi…

6c1573e

…sts.txt

Turn off openfx module on msvc CI/CD build

2bb7cd2

joinlaw force-pushed the openfx branch from d3cad6a to 2bb7cd2 Compare January 2, 2026 12:40

		/* TODO: add support for OpenGL plugins */
		propSetString(host_properties, kOfxImageEffectPropOpenGLRenderSupported, 0, "false");

OpenFX Module #1186

Are you sure you want to change the base?

OpenFX Module #1186

Uh oh!

Conversation

joinlaw commented Dec 16, 2025

Uh oh!

joinlaw commented Dec 16, 2025

Uh oh!

luzpaz commented Dec 19, 2025

Uh oh!

joinlaw commented Dec 20, 2025

Uh oh!

ddennedy commented Dec 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ddennedy Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ddennedy Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

izakikoparadox commented Dec 21, 2025

Uh oh!

bmatherly commented Dec 31, 2025

Uh oh!

joinlaw commented Dec 31, 2025

Uh oh!

bmatherly Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

joinlaw Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

bmatherly Jan 1, 2026

Choose a reason for hiding this comment

Uh oh!

joinlaw Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

ddennedy commented Jan 2, 2026

Uh oh!

bmatherly commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joinlaw commented Jan 3, 2026

Uh oh!

ddennedy commented Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bmatherly commented Jan 3, 2026 •

edited

Loading