Add Settings > Preview Scaling > Use Hardware Decoder #1761
+92
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new setting to enable/disable hardware decoder usage in the preview player. The feature allows users to toggle hardware-accelerated decoding through the Settings > Preview Scaling menu, configuring platform-specific hardware decoders (VideoToolbox on macOS, D3D11VA on Windows, VAAPI on Linux).
Key Changes:
- Added UI option to toggle hardware decoder in preview scaling menu
- Implemented hardware decoder configuration logic with platform-specific support
- Added safety checks to prevent invalid producer/consumer operations
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mainwindow.ui | Added "Use Hardware Decoder" action to preview scaling menu |
| src/mainwindow.h | Added slot declaration for hardware decoder toggle handler |
| src/mainwindow.cpp | Implemented hardware decoder toggle handler and initialization logic |
| src/settings.h | Added getter/setter declarations for hardware decoder preference |
| src/settings.cpp | Implemented hardware decoder preference storage with default value true |
| src/mltcontroller.h | Added hardware decoder configuration method declaration |
| src/mltcontroller.cpp | Implemented platform-specific hardware decoder configuration logic |
| src/videowidget.cpp | Added producer validation check and preview scale configuration |
| src/player.cpp | Added safety check for invalid producer in onProducerOpened |
| src/jobs/meltjob.cpp | Removed hardware decoder environment variable for background jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PPS = maximum pixels per second to use hwaccel. The purpose of this is to permit usage of hardware decoding without preview scale but only for video <= 1080p60. Otherwise, the data is too much especially for multiple transfers (movit and/or preview).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.