fixed raised error not being caught in class#12
Open
wongkaiweng wants to merge 1 commit intommwise:groovy-develfrom
Open
fixed raised error not being caught in class#12wongkaiweng wants to merge 1 commit intommwise:groovy-develfrom
wongkaiweng wants to merge 1 commit intommwise:groovy-develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found out a Runtime Error of Bad SOF is raised in the
recvfunction but it is not caught in its callerrun. Instead of raising the error, I changed the code to write to stdout and clear data instead. With this change, I was able to retrieve data again.The other way to do it would be putting
while self.is_connected and not self.shutdown:in the functionrun. We can then catch the error there and continue.