Skip to content

Comments

fix: patch axios temporarily / bump version#427

Merged
mnahkies merged 2 commits intomainfrom
mn/test/axios-patch
Feb 18, 2026
Merged

fix: patch axios temporarily / bump version#427
mnahkies merged 2 commits intomainfrom
mn/test/axios-patch

Conversation

@mnahkies
Copy link
Owner

@mnahkies mnahkies commented Feb 18, 2026 •
edited
Loading

bumping axios without this patch leads to type checking errors as seen here https://github.com/mnahkies/openapi-code-generator/actions/runs/22118781975/job/63933672790

...
  The types of 'config.transformRequest' are incompatible between these types.
    Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer[]' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/...'.
      Type 'AxiosRequestTransformer' is not assignable to type 'AxiosRequestTransformer | AxiosRequestTransformer[]'.
        Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).AxiosRequestTransformer'.
          The 'this' types of each signature are incompatible.
            Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).InternalAxiosRequestConfig<any>' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").InternalAxiosRequestConfig<any>' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
              Types of property 'transformRequest' are incompatible.
                Type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index", { with: { "resolution-mode": "import" } }).AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/...' is not assignable to type 'import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer | import("/home/runner/work/openapi-code-generator/openapi-code-generator/node_modules/.pnpm/axios@1.13.5/node_modules/axios/index").AxiosRequestTransformer[]'.
                  Type 'AxiosRequestTransformer' is not assignable to type 'AxiosRequestTransformer | AxiosRequestTransformer[]'.

The message is obtuse, but ultimately it's caused by axios/axios#5560 creating an incompatibility between the cjs and esm typings.

Upstream fix submitted: axios/axios#7414

mnahkies added a commit to mnahkies/axios that referenced this pull request Feb 18, 2026
@mnahkies
fix(types): align cjs cancelToken types
fed4d6d 
the import/esm types include `undefined` (ref:
https://github.com/axios/axios/blob/v1.x/index.d.ts#L457)

this was added recently in axios#5560 - but only to `index.d.ts`,
which can break type-checking in projects using a mixture
of cjs and esm, when `exactOptionalPropertyTypes` is enabled,
as it makes the request config types incompatible with eachother.

you can see an example of the type error / this patch resolving
it on mnahkies/openapi-code-generator#427
@mnahkies mnahkies mentioned this pull request Feb 18, 2026
Open
@mnahkies mnahkies marked this pull request as ready for review February 18, 2026 20:47
@mnahkies mnahkies merged commit 05928e3 into main Feb 18, 2026
22 checks passed
@mnahkies mnahkies deleted the mn/test/axios-patch branch February 18, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mnahkies