[US] Établir un rapport de tous les paramètres d'entrée #198#240
Open
mariegrandclement wants to merge 4 commits intomainfrom
Open
[US] Établir un rapport de tous les paramètres d'entrée #198#240mariegrandclement wants to merge 4 commits intomainfrom
mariegrandclement wants to merge 4 commits intomainfrom
Conversation
Fonction parameters_dict mise à jour pour séparer les paramètres généraux, liés aux modes, et liés aux motifs
Contributor
Mind-the-Cap
left a comment
There was a problem hiding this comment.
Very good first draft, let's include all parameters!
examples/quickstart-fr.py.py
Outdated
Contributor
There was a problem hiding this comment.
Good idea to put it here! Can we stick to English (report) ? Let's add a comment to help future users understand what it does
Contributor
|
Suite à notre discussion, je propose les modifications suivantes :
|
Created class Parameter (using model_parameters.py made by Capucine) Created function get_parameters in class FileAsset, with a recursive attribute, in order to get all unique parameters of the object (if recursive=false) or the parameters of the object and all upper objects (if recursive=true). Modified function compute_inputs_hash from class Asset in order to manage the fact that some inputs are now Parameters objects Modified class StudyArea in order to define radius as a Parameter Modified class TransportZones in order to define level_of_detail as a Parameter Tested transport_zones.get_parameters() in quickstart
Contributor
Author
|
New approach using class Parameter and function get_parameters in FileAsset
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR liée à l'US #198
Ajout d'une fonction parameters_dict dans la classe PopulationTrips pour récupérer les paramètres suivants :
Modification de la fonction plot_od_flows de la classe PopulationTrips pour afficher la liste des paramètres et le hash sur la carte.
Reste à faire :