Disallow certain entities in space#551
Open
Qatavin wants to merge 16 commits intomodded-factorio:devfrom
Open
Conversation
Contributor
|
As much as possible I think we should avoid checking for if Space Age mod is enabled. This will be better for mod compatibility. Using surface conditions requires the |
Collaborator
Author
|
I suppose, if it works. The freezing parts do need to be Space Age dependent, though, since they reference assets that are contained within the mod. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pertains to #547
Adds surface_conditions to various entities where appropriate so they will not be able to be built in space or other inappropriate locations.
Burner assembly machine, burner electric generator and fluid burning generators, burner heat sources, stone and steel and fluid burning chemical/mixing furnaces, roboports of all kinds, and burner labs are all banned from airless environments.
Locomotives, cars, and tanks have added condition that blocks them from airless environments (previously they only had the gravity limitation) due to their burner engines. Spidertrons will also have the gravity requirement, and the ones with burner power sources (depending on the setting) will also require air pressure.
Blocked from 0g environments but not airless ones: greenhouse (an enclosed environment, so no air is okay, but plants don't grow well without gravity), chests/logistic chests, ground combat drones other than flamethrower drone (which also needs air)
Steam mining drill changed so that it is allowed to be used with no atmosphere.
There are also some weight modifications in there. I'm working on that too, mostly in a separate branch. It's badly needed, as some of the rocket capacity calculations are very odd if you let them be generated automatically.