Skip to content

Conversation

@wpbonelli
Copy link
Member

Fix #2420, only internal arrays in this PR. Introduce a single underlying variable to track whether max_columns_of_data has been set automatically or by the user. Keep the 2 existing user-facing flags for backwards-compatibility, but reimplemented as properties to reflect the neater internal management. This should eliminate the need to ever set these.

And reproduce the external array problem. There are tricky interactions between whether max_columns_of_data is set first or data is set external first, and whether the simulation workspace has been changed. Currently the column setting is only respected for external arrays if the simulation workspace has been changed and the column setting is set before setting data external. Ideally the setting would be respected regardless of order of ops or whether the workspace is different.

@wpbonelli wpbonelli added this to the 3.9.6 milestone Dec 12, 2025
@wpbonelli wpbonelli added the bug label Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.6%. Comparing base (556c088) to head (3563b61).
⚠️ Report is 92 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/mf6/mfsimbase.py 95.8% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2665      +/-   ##
===========================================
+ Coverage     55.5%    72.6%   +17.1%     
===========================================
  Files          644      667      +23     
  Lines       124135   129386    +5251     
===========================================
+ Hits         68947    94018   +25071     
+ Misses       55188    35368   -19820     
Files with missing lines Coverage Δ
flopy/mf6/mfmodel.py 56.9% <100.0%> (-24.0%) ⬇️
flopy/mf6/mfsimbase.py 62.6% <95.8%> (-12.8%) ⬇️

... and 557 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review December 12, 2025 15:26
@wpbonelli wpbonelli merged commit 543130b into modflowpy:develop Dec 12, 2025
20 checks passed
@wpbonelli wpbonelli deleted the fix-2420 branch December 12, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: max_columns_of_data ignored for simulations loaded from file

1 participant