Open
Conversation
- Before this change, ratios couldn't be used by consumers of this module. - This is a breaking API change that should result in a major version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this change is to allow us to do:
import { ms, ratios } from 'modularscale-js'and subsequently do:
const fontSize = ms(2, { base: 18, ratio: ratios.goldenSection })On a side note I thought the number alignment looked odd in the object literal, but I'll happily amend the commit if you want me to reimplement that.
Also, I might have some more suggestions to improving this module if you are open to it :)