Modernize modular scale

[scottkellum]

Bring Modular Scale up to current Sass standards.

• Switch to @use from @import to more safely scope the library SyntaxError on @import #161
• Use new math module
• Update responsive logic to use Typetura, clamp(), and updated CSS Locks logic ms-respond for shorthand? #148 Implement a way to disable viewport-based typography in version 3 ($ms-fluid: false) #155 No mixin named ms-respond #168
• Change division method to the new standard Deprecation warnings after upgrading Sass when using ms Variable #171

[scottkellum]

Please test this out here: https://github.com/modularscale/modularscale-sass/releases/tag/v4.0.0.rc1

[robsonsobral]

Hi, Scott!

Why not to move the _modularscale.scss to modularscale/_index.scss? The @use stays the same, but the files are kept all within a single folder.

I'm sorry for bother you twice in a day.

[scottkellum]

@robsonsobral Not a bother! Happy to get feedback!

[robsonsobral]

@scottkellum ? Have you given it up?

[scottkellum]

@robsonsobral Ha yeah I have no time for this for the next few months 😅🙃

[robsonsobral]

I think we have a good thing here, @scottkellum . Let's give it some time?

[scottkellum]

Just want to let you know I see this and am trying to figure out how to allocate time to wrap this up.

[Lukortech]

I wanted to bump it a bit as I have some deprecation warnings while using this fantastic tool.
If there's any way I could help out let me know @scottkellum

[robsonsobral]

@Lukortech , I'm so sorry for letting you (and @scottkellum ) down.

I saw your message and planned to use a Brazilian holiday last week to take care of things, but I got sick.

Can you give some time to update the code?

[scottkellum]

I feel that if I wade into this, I will only be a bottleneck. I’ve been drifting further and further away from this project. @robsonsobral and @Lukortech, feel free to merge PRs and push changes as you see fit. A code review might be wanted, so @Lukortech, maybe you can offer that when @robsonsobral is ready?

[robsonsobral]

I've updated the syntax, @Lukortech ! Now, we're using the latest versions of SASS and True! Now, I need to review things, specially the related to @scottkellum 's Typetura, as I don't know it.

[scottkellum]

Typetura stuff should probably be removed at this point.

[Lukortech]

The long awaited change 🚀

[scottkellum]

@Lukortech Thank you for your review. I added you as a maintainer if you wish to take a more active role.

@robsonsobral are we ready to go?

[robsonsobral]

@scottkellum , I opened 2 issues that need fixing, and I'm working on them.

@Lukortech , sorry, but I can only work on this project on weekends.