Fix PHP 8+ deprecation warnings breaking JSON parsing#72
Open
Swahjak wants to merge 1 commit intomoetelo:masterfrom
Open
Fix PHP 8+ deprecation warnings breaking JSON parsing#72Swahjak wants to merge 1 commit intomoetelo:masterfrom
Swahjak wants to merge 1 commit intomoetelo:masterfrom
Conversation
Pass `-d display_errors=stderr` to PHP executable to redirect deprecation warnings to stderr, keeping stdout clean for JSON output. Since PHP 8.0, the default error_reporting includes E_DEPRECATED, causing deprecation notices to pollute stdout and break JSON parsing in the language server.
7a9f273 to
01767fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-d display_errors=stderrto PHP executable when invoking commandsProblem
Since PHP 8.0, the default
error_reportingincludesE_DEPRECATED, causing deprecation notices to be output to stdout. This pollutes the JSON output from commands likebin/console debug:twig --format json, breaking the language server's JSON parsing.Fixes #69
Approach
As suggested by @moetelo in #71, this uses PHP's
-dflag to setdisplay_errors=stderrat runtime. This ensures errors are redirected before any PHP code executes, making it effective even when deprecations occur in early bootstrap code (e.g., before Craft CMS can suppress them).This approach is preferable to stripping text before JSON (as proposed in #71) because:
{or[charactersTest plan