fix(connection-manager): remove helm hooks breaking gitops#780
Draft
fix(connection-manager): remove helm hooks breaking gitops#780
Conversation
hooks delete SA/secrets after migration, causing pod restart failures. migration job now uses image version hash in name instead.
kirgene
force-pushed
the
fix/remove-helm-hooks-gitops
branch
from
7b7f11f to
6cad7d0
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helm hooks delete SA/secrets after migration succeeds, so pod restarts fail.
migration job now uses image version hash in name - only runs when image changes.