Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Comments

Fixed #64 - showConsoleWindow=false causes JavaFx window to start min…#113

Closed
seanidzenga wants to merge 1 commit intomojohaus:masterfrom
seanidzenga:patch-1
Closed

Fixed #64 - showConsoleWindow=false causes JavaFx window to start min…#113
seanidzenga wants to merge 1 commit intomojohaus:masterfrom
seanidzenga:patch-1

Conversation

@seanidzenga
Copy link

@seanidzenga seanidzenga commented Dec 9, 2020

Same as @leif81

noticed this wasn't fixed today when I went to use the <showConsoleWindow> configuration

@seanidzenga
Copy link
Author

@khmarbaise As with Leif's PR there seems to be something misconfigured with Travis CI - if you'd like I can look in to it given the appropriate credentials do so.

@khmarbaise
Copy link
Member

This is unrelated to credentials it's simply related to the usage of JDK 7 which is not available anymore on those areas ...apart from general problems on travis-ci https://blog.travis-ci.com/oss-announcement ... it looks like it became time to migrate to something different like Github actions etc.

@leif81
Copy link

leif81 commented Dec 10, 2020

@seanidzenga hah great minds.

Same fix as #65

@seanidzenga
Copy link
Author

This is unrelated to credentials it's simply related to the usage of JDK 7 which is not available anymore on those areas ...apart from general problems on travis-ci https://blog.travis-ci.com/oss-announcement ... it looks like it became time to migrate to something different like Github actions etc.

Sorry my wording was unclear, I meant "if I were provided the appropriate credentials I could try and fix it"

@khmarbaise Is there a plan to migrate to GitHub actions already in place?

@seanidzenga seanidzenga reopened this Apr 28, 2021
@seanidzenga
Copy link
Author

@khmarbaise so what's going on with your Travis CI configuration? what needs to happen to have these PRs accepted?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants