This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Fix problem with spaces in JAVACMD or CLASSPATH for windows batch scripts#179
Open
opax wants to merge 2 commits intomojohaus:masterfrom
Open
Fix problem with spaces in JAVACMD or CLASSPATH for windows batch scripts#179opax wants to merge 2 commits intomojohaus:masterfrom
opax wants to merge 2 commits intomojohaus:masterfrom
Conversation
|
@opax On a quick read I think that your patch will break in case of an unset JAVACMD env variable the case of As JAVACMD, if unset, is set to JAVA_BINARY in the template. If you then later quote JAVACMD it will look for a binary called "start /min javaw" instead of a binary "start" with arguments "/min" and "javaw" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve issue #114 .
In addition to the quoted
JAVACMD,CLASSPATHis also quoted so that spaces in the classpath do not crash the batch script.The test expectations have been updated accordingly.