This repository was archived by the owner on Oct 8, 2025. It is now read-only.
First proposal to resolve issue #51.#53
Open
ramiromagalhaes wants to merge 2 commits intomojohaus:masterfrom
ramiromagalhaes:fix51
Open
First proposal to resolve issue #51.#53ramiromagalhaes wants to merge 2 commits intomojohaus:masterfrom ramiromagalhaes:fix51
ramiromagalhaes wants to merge 2 commits intomojohaus:masterfrom
ramiromagalhaes:fix51
Conversation
Contributor
|
@ramiromagalhaes thanks for the patch, however, I have a feeling this is to compensate for your VPN flakiness. or a very slow disk io |
Author
|
Well, you are absolutely right. That is indeed the reason why I raised the
issue. I guess it won't be a very helpful feature to most users, and there
are workarounds I can try. Just thought that integrating it in the plugin
would be nice. Thank you anyway.
2016-11-25 16:31 GMT-02:00 Dan Tran <notifications@github.com>:
… @ramiromagalhaes <https://github.com/ramiromagalhaes> thanks for the
patch, however, I have a feeling this is to compensate for your VPN
flakiness. or a very slow disk io
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkehHdDpEhjamUbPo0uKlndIf09da9kks5rBymVgaJpZM4K8hm->
.
|
Author
|
Is it acceptable to change the patch in such a way that it always (independent of configuration) checks if the artifact already exists in its destination and if its has the same size of the source artifact to then decide to copy it to its destination? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this is a first proposal to solve issue #51 . I am still testing it, but I'd like to know if the general approach is acceptable.