This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a daemon, the init.d script use a PID to track the process. Usually PID are stored in /run or /var/run.
In case of daemon running as non-root, the PID dir must be writable by the daemon user. The solution was to create a folder /var/run/daemon-name/ owned the the daemon user. The folder was created during installation (e.g. in the package .rpm or .deb).
But in most current Linux distribution (at least Ubuntu, CentOS and Fedora), /var/run and /run are tmpfs which is not persisted across reboot, so the /var/run/daemon-name/ need to be re-created.
This PR add the creation of the PID dir and changing ownership to user.
It will fix jmxtrans issue jmxtrans/jmxtrans#578