Skip to content

wp#89

Closed
mokimo wants to merge 299 commits intomainfrom
stage
Closed

wp#89
mokimo wants to merge 299 commits intomainfrom
stage

Conversation

@mokimo
Copy link
Owner

@mokimo mokimo commented Mar 18, 2025

  • Add your
  • Specific
  • Features or fixes

Resolves: MWPW-NUMBER

Test URLs:

bandana147 and others added 30 commits January 7, 2025 09:16
* Ading uncConfig for unav

* Ading uncConfig for unav

* Lint fix
* MWPW-162385 add wcsApiKey attribute

* MWPW-161355: Update MAS documentation (adobecom#3135)

* MWPW-159374: Update hydrate logic

to support all cta styles
organise code and code coverage

Update tests

* add workaround for ccd-suggested cards

* remove source maps

* improve code coverage

* merge MWPW-159374

* MWPW-161355: Update MAS documentation

* Example with contextual menu
* Checkout click event with correct event target
 when the CTA contains a text wrapped by a span

* cleanup all attributes during card hydration

* remove deps/mas/mas.js

* update test

* update doc

* allow list libs/features/mas/mas/dist/mas.js

* change order in ignore

* trying with wildcard

* allow list dist

* update hlxignore rules

* update hlxignore rules

* MWPW-161176: restructure ccd gallery (adobecom#3169)

restructure ccd gallery

* fix mas path

* fix undefined error in merch-icon

* fix regression in ctas size

* update doc

* fix css with checkout-link

* fix random rtl issue

* revert removal of mas.js from deps

* update ccd gallery

---------

Co-authored-by: Mariia Lukianets <lukianet@adobe.com>

* MWPW-161845: basic analytics on mas cards (adobecom#3206)

* MWPW-161845: add analytics

* fix review changes

* add build files

* MWPW-159191: MAS Freyja support (adobecom#3209)

* initial freyja commit

* increase codecov

* trival

* add qa support to ccd page

* improve page performance

* update ccd.html

* MWPW-161804: Merch card style auditing (adobecom#3216)

Refactor merch-card styles to improve structure and specificity

* Added space after price recurrence label for display-per-unit prices (adobecom#3196)

* Added space after price recurrence label for display-per-unit prices

* more specific selector

* built

* fix cr

* built

* adding example

* MWPW-162933: merge mas modules (adobecom#3248)

* MWPW-162933: merge mas modules

+ consonant-templates module from tacocat.js
into a single module

* MWPW-160755 - add tests for CCD cards (adobecom#3256)

* MWPW-160755 - add tests for CCD cards

* refactor and prepare dark mode checks

* add tests for slice cards

* activate dark for suggested and eslint fixes

* add check for cta variant

* fix multi mnemonic check

* fix lint

* add analytics check

* remove comment

* MWPW-163041: analytics fix (adobecom#3257)

* MWPW-163041: fix analytics & add docs

* add tests for analytics

* add analytics docu

* fix test

* Fix overriding of border style on merch cards (adobecom#3278)

* Fix overriding of border style on merch cards

* width change

* built

---------

Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>

* Bump timeout from 2 to 10 sec (adobecom#3282)

* bump to 10 seconds

* new change

* MWPW-163479: Switch to Spectrum CSS from SWC

CCD app already provides Spectrum CCS styles.

* update doc style

* update doc style

* update doc style

* update doc style

* update doc style

* update doc style

* Update styles

* update docs

* Keep SWC logic as an option

* MWPW-161645: lana logging for CCD (adobecom#3271)

* MWPW-161645: lana logging for CCD

with <mas-commerce-service data-lana-tags="consumer=ccd" ...>

lana will be enabled.

TODO:

Update docs

* Update tests

* fix review comments

* add host env attribute, fix lana override

* fix docs

* fix unit tests

* start loggin missing osi's

* fix message

* fix message

* Update libs/features/mas/src/lana.js

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* PR review changes

* avoid duplicate logging, log wcs url, limit page length in log

* fix formatString error

* fix render

* add tests

* fix loggin

* revert ccd comments

* fix milo tags

---------

Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* fix gaps with Spectrum CSS support

* update version

* fix gaps reported by ccd teamm

* address gaps

* address gaps

* address gaps

* address gaps

* address gaps

* fix for MWPW-163718

addressed design gaps.

* addressed design gaps.

* bump the version

* add build artifacts

* Update colors based on CCD app

* Update colors based on CCD app

* build without source maps

* update Nala tests

* fix lint

* reset box-sizing for merch-card elements

* Force box-sizing on merch-card

* update styles: box-sizing

* fix ccd gallery

* update version

* limit ccd price style to their variants

* limit ccd price style to suggest variant

* preserve white spaces in prices section

* fix spacing in price

* Update version

* Update doc

* update cards

* update gallery styles

* make the gallery responsive

* align slice card ctas

* cards resize responsively

* fix 1x of gap issue

* fix description text alignement

* fix gaps in minimal widths

* fix the gallery layout

* Fix strikethrough price color in promos

* Update nala tests

* MWPW-164177: clean up card style on fragment

* Added a new section to ccd gallery

* update mas version

* fix missing default spectrum css button style

---------

Co-authored-by: Nicolas Peltier <npeltier@adobe.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Milica Micic <cod23684@adobe.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
* MWPW-150560 make search literals usable as fragments

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)"

This reverts commit 81a5770.

* review comment

* Update libs/blocks/merch-card-collection/merch-card-collection.js

Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>

* fix unit test

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
* MWPW-162046 Tabs - Stacked Mobile

* figma review adjustments

* remove unused variable
…odal (adobecom#3375)

* MWPW-164084 [Catalog] Page position not preserved after closing the modal

* Trigger Build

* MWPW-164084 [Catalog] Page position not preserved after closing the modal

* MWPW-164084 [Catalog] Page position not preserved after closing the modal

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
* MWPW-159299 Add chart role

* Update echarts library and dynamically set aria text

* Update aria settings
* Comp Web App Sign In

* Comp Sign In

* Complimentary CTA test cases and structural change

* Adding Complimentary CTA block under synthetic blocks

* Changing the reference to Product Entry CTA

* Changing the reference to Product Entry CTA

---------

Co-authored-by: Akansha Arora <>
…om#3397)

* MWPW-164227 add checkmark animation on successful form submit

* MWPW-164227 cleanup code
* fix(sticky): Adjust sticky section top offset to align with header height initialy

* chore: handled header absent

* fix: removing hide class when no-delay is present
…rds (adobecom#3360)

* MWPW-161865: adds alt text attribute to background images of merch cards

* nit fix
* MWPW-164094 Fix algorithm for calculation of PUF optical

* Trigger Build

* Trigger Build

* Generate mas and commerce

* Generate mas

* Trigger Build

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
…adobecom#3379)

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)"

This reverts commit 81a5770.

* MWPW-163075: Updates local caas-tags file with the latest tags

* MWPW-163075: Updates local caas-tags file with the latest tags II

* Resolves BulkPublisher country/lang issue

* MWPW-164327: Splits PR into two, one of each bug

* MWPW-164327: Splits PR into two, one of each bug

* MWPW-164327: Splits PR into two, one of each bug

* MWPW-164327: Splits PR into two, one of each bug

* MWPW-164327: modifies file matching logic

* MWPW-164327: modifies file matching logic

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
* image size is 40px| overriden styles made more specific

* play/pause button is synced when carousel containing video is slided
…dobecom#3385)

- allow /search/ and /results/ token that are easy to set in 'do not translate' mode,
- add unit test
- add additional safeguard to slot text retrieval,
…unt (adobecom#3416)

* account for no stageDomainsMap

* add unit test

* less redundant

* Update libs/features/personalization/preview.js

add nala folder to exclusions

* MWPW-164805 [MMM] Add manifest count to page list (adobecom#3430)

* ServiceNow CMR integration (adobecom#3392)

* added servicenow CMR template

added servicenow CMR template for github actions

* updated template to remove skms

updated template to remove skms and swap it with ServiceNow

* started adding servicenow api calls

started adding servicenow api calls

* added the servicenow cmr calls.

added the servicenow cmr calls.

* test branch added

test branch added

* removed skms.yml where we are using servicenow

removed skms.yml where we are using servicenow

* updated function calls and parameters

updated function calls and parameters

* test update

test update

* Updated calls to output to file and check output

Updated calls to output to file and check output for successful curl calls.  Fixes jq parsing command.

* testing output

testing output

* fixed github env variable declarations

fixed github env variable declarations for token, cmr_id, transaction_id, release_title

* added output to console for response from curl

added output to console for response from curl

* fixed file existence and size check

fixed file existence and size check

* small update

small update

* fixed curl statements and timestamps

fixed curl statements and timestamps

* another small update

another small update

* testing

testing

* testing theory

testing theory

* testing arguments

testing arguments

* second attempt

second attempt

* updated branch to remove caching

updated branch to remove caching from GitHub Actions, hopefully.

* reverted changes of new branch

reverted changes of new branch

* another small fix

another small fix

* testing a thought

testing a thought

* moved release summary to last param

moved release summary to last param where it stops other parameters from being read.

* testing out semantics for env variables

testing out semantics for env variables

* updated shell commands to fix errors

updated shell commands to fix errors

* small github env fixes

small github env fixes

* updated curl statement

updated curl statement

* updated calls and timespans

updated calls and timespans

* added printouts for debugging

added printouts for debugging

* small fixes

small fixes

* updated calls per guidance from winter solstice

updated calls per guidance from winter solstice team

* added new python script and removed shell script

added new python scripts and removed shell script

* added sanitization method

added sanitization method

* updated servicenow integration to use python

updated servicenow integration to use python

* updated variables and added headers

updated variables and added headers

* fixed cmr_id parsing and cmr closing

fixed cmr_id parsing and cmr closing

* added small test change for PR

added small test change for PR

* updated execution path

* fixing environment variable access

fixing environment variable access

* fixed branches in yaml

fixed branches in yaml

* updated approvers, removed executor

updated approvers, removed executor so that the default "Change Management API Integration" user is used instead.

* changed stage variables, urls to prod

changed stage variables, urls to prod

* Add unc activity feed support for standalone gnav (adobecom#3386)

* Ading uncConfig for unav

* Ading uncConfig for unav

* Lint fix

* MWPW-163479: MAS - Switch to Spectrum CSS from SWC (adobecom#3289)

* MWPW-162385 add wcsApiKey attribute

* MWPW-161355: Update MAS documentation (adobecom#3135)

* MWPW-159374: Update hydrate logic

to support all cta styles
organise code and code coverage

Update tests

* add workaround for ccd-suggested cards

* remove source maps

* improve code coverage

* merge MWPW-159374

* MWPW-161355: Update MAS documentation

* Example with contextual menu
* Checkout click event with correct event target
 when the CTA contains a text wrapped by a span

* cleanup all attributes during card hydration

* remove deps/mas/mas.js

* update test

* update doc

* allow list libs/features/mas/mas/dist/mas.js

* change order in ignore

* trying with wildcard

* allow list dist

* update hlxignore rules

* update hlxignore rules

* MWPW-161176: restructure ccd gallery (adobecom#3169)

restructure ccd gallery

* fix mas path

* fix undefined error in merch-icon

* fix regression in ctas size

* update doc

* fix css with checkout-link

* fix random rtl issue

* revert removal of mas.js from deps

* update ccd gallery

---------

Co-authored-by: Mariia Lukianets <lukianet@adobe.com>

* MWPW-161845: basic analytics on mas cards (adobecom#3206)

* MWPW-161845: add analytics

* fix review changes

* add build files

* MWPW-159191: MAS Freyja support (adobecom#3209)

* initial freyja commit

* increase codecov

* trival

* add qa support to ccd page

* improve page performance

* update ccd.html

* MWPW-161804: Merch card style auditing (adobecom#3216)

Refactor merch-card styles to improve structure and specificity

* Added space after price recurrence label for display-per-unit prices (adobecom#3196)

* Added space after price recurrence label for display-per-unit prices

* more specific selector

* built

* fix cr

* built

* adding example

* MWPW-162933: merge mas modules (adobecom#3248)

* MWPW-162933: merge mas modules

+ consonant-templates module from tacocat.js
into a single module

* MWPW-160755 - add tests for CCD cards (adobecom#3256)

* MWPW-160755 - add tests for CCD cards

* refactor and prepare dark mode checks

* add tests for slice cards

* activate dark for suggested and eslint fixes

* add check for cta variant

* fix multi mnemonic check

* fix lint

* add analytics check

* remove comment

* MWPW-163041: analytics fix (adobecom#3257)

* MWPW-163041: fix analytics & add docs

* add tests for analytics

* add analytics docu

* fix test

* Fix overriding of border style on merch cards (adobecom#3278)

* Fix overriding of border style on merch cards

* width change

* built

---------

Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>

* Bump timeout from 2 to 10 sec (adobecom#3282)

* bump to 10 seconds

* new change

* MWPW-163479: Switch to Spectrum CSS from SWC

CCD app already provides Spectrum CCS styles.

* update doc style

* update doc style

* update doc style

* update doc style

* update doc style

* update doc style

* Update styles

* update docs

* Keep SWC logic as an option

* MWPW-161645: lana logging for CCD (adobecom#3271)

* MWPW-161645: lana logging for CCD

with <mas-commerce-service data-lana-tags="consumer=ccd" ...>

lana will be enabled.

TODO:

Update docs

* Update tests

* fix review comments

* add host env attribute, fix lana override

* fix docs

* fix unit tests

* start loggin missing osi's

* fix message

* fix message

* Update libs/features/mas/src/lana.js

Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* PR review changes

* avoid duplicate logging, log wcs url, limit page length in log

* fix formatString error

* fix render

* add tests

* fix loggin

* revert ccd comments

* fix milo tags

---------

Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>

* fix gaps with Spectrum CSS support

* update version

* fix gaps reported by ccd teamm

* address gaps

* address gaps

* address gaps

* address gaps

* address gaps

* fix for MWPW-163718

addressed design gaps.

* addressed design gaps.

* bump the version

* add build artifacts

* Update colors based on CCD app

* Update colors based on CCD app

* build without source maps

* update Nala tests

* fix lint

* reset box-sizing for merch-card elements

* Force box-sizing on merch-card

* update styles: box-sizing

* fix ccd gallery

* update version

* limit ccd price style to their variants

* limit ccd price style to suggest variant

* preserve white spaces in prices section

* fix spacing in price

* Update version

* Update doc

* update cards

* update gallery styles

* make the gallery responsive

* align slice card ctas

* cards resize responsively

* fix 1x of gap issue

* fix description text alignement

* fix gaps in minimal widths

* fix the gallery layout

* Fix strikethrough price color in promos

* Update nala tests

* MWPW-164177: clean up card style on fragment

* Added a new section to ccd gallery

* update mas version

* fix missing default spectrum css button style

---------

Co-authored-by: Nicolas Peltier <npeltier@adobe.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Milica Micic <cod23684@adobe.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>

* MWPW-150560 make search literals usable as fragments (adobecom#3320)

* MWPW-150560 make search literals usable as fragments

* Revert "MWPW-140452 - Icon authoring in milo using the federal repo a… (adobecom#3357)

Revert "MWPW-140452 - Icon authoring in milo using the federal repo and individual SVG assets (adobecom#3259)"

This reverts commit 81a5770.

* review comment

* Update libs/blocks/merch-card-collection/merch-card-collection.js

Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>

* fix unit test

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>

* MWPW-162046 Tabs - Stacked Mobile (adobecom#3351)

* MWPW-162046 Tabs - Stacked Mobile

* figma review adjustments

* remove unused variable

* MWPW-164084 [Catalog] Page position not preserved after closing the modal (adobecom#3375)

* MWPW-164084 [Catalog] Page position not preserved after closing the modal

* Trigger Build

* MWPW-164084 [Catalog] Page position not preserved after closing the modal

* MWPW-164084 [Catalog] Page position not preserved after closing the modal

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>

* [MWPW-161858] Remove sticky section when footer is visible (adobecom#3402)

remove sticky section when footer is visible

* MWPW-159299 Add chart role and dynamic aria labels (adobecom#3404)

* MWPW-159299 Add chart role

* Update echarts library and dynamically set aria text

* Update aria settings

* MWPW-156410: add daa-lh/ll values for gnav promo (adobecom#3413)

* MWPW-162760 [MEP] Issues with inline fragments (adobecom#3415)

initial push

* created number of activities for pages

* updated tests

* updated activities number positioning

* Update libs/blocks/mmm/mmm.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update libs/blocks/mmm/mmm.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update libs/blocks/mmm/mmm.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update libs/blocks/mmm/mmm.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update libs/blocks/mmm/mmm.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update libs/blocks/mmm/mmm.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* css change

---------

Co-authored-by: Aaron Mauchley <mauchley@adobe.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Ilyas Türkben <tuerkben@adobe.com>
Co-authored-by: Nicolas Peltier <npeltier@adobe.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Milica Micic <cod23684@adobe.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Brandon Marshall <bmarshal@adobe.com>
Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com>
Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Denys Fedotov <denlight@gmail.com>
Co-authored-by: Aaron Mauchley <mauchley@adobe.com>
Co-authored-by: Bandana Laishram <bandanalaishram@gmail.com>
Co-authored-by: Ilyas Türkben <tuerkben@adobe.com>
Co-authored-by: Nicolas Peltier <npeltier@adobe.com>
Co-authored-by: Mariia Lukianets <lukianet@adobe.com>
Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com>
Co-authored-by: Angelo Statescu <angelostatescu.adobe@gmail.com>
Co-authored-by: Milica Micic <cod23684@adobe.com>
Co-authored-by: Mariia Lukianets <mariia.lukianets@gmail.com>
Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>
Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com>
Co-authored-by: Megan Thomas <methomas@adobe.com>
Co-authored-by: Bozo Jovicic <37440641+bozojovicic@users.noreply.github.com>
Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
Co-authored-by: Brandon Marshall <bmarshal@adobe.com>
Co-authored-by: nishantka <126539566+nishantka@users.noreply.github.com>
Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* add test implementation for language based region nav

* MWPW-164320 remove demo stuff

* MWPW-164320 add unit tests

* MWPW-164320 prevent multiple head requests on links that have already been checked

* MWPW-164320 unflatten code

* MWPW-164320 fix callback
* table header bug fix

* resolved evet added

* once settled added

* table heading height handling

* setInterval approach

* mas:resolved added to parent element

* reverted unwanted changes

* reverted unwanted changes

* height calculated for tables without pricing

* added test cases

* Revert "added test cases"

This reverts commit a1f8667.

* Reapply "added test cases"

This reverts commit 4966fc7.

* reverted
* MWPW-163602 draft

* some fixes

* add benchmark test to Nala

* fix adjust

* bring adjusted limit to nala too

* MWPW-163603 review comments

* forgot to rebuild docs

* review comments

* latest

* make sidenav smaller :)

* yet a bit smaller :)

* fix benchmark selector

* use aside

* desperate try to fool cov

---------

Co-authored-by: cod23684 <cod23684@adobe.com>
Adding bottom spacing

Co-authored-by: Ryan Clayton <rclayton@adobe.com>
* adding save today on ctaTextOption

* Update the unit test.
…m#3389)

* Setting aria-live to shadowRoot element instead to the slot.

* Update unit test.

* Adding escape in case there is no resultText.

* Moving the aria-live code to mas
* List accessibility for quiz-marquee
<!-- Before submitting, please review all open PRs. -->

* Update quiz-marquee authoring to denote nested lists
* roles for list and listitem in quiz-marquee and quiz-results

Resolves: [MWPW-165027](https://jira.corp.adobe.com/browse/165027-NUMBER)

* PR feedback
sanrai and others added 23 commits March 11, 2025 08:11
…ery parameter (adobecom#3753)

cherry-picking previous fix

Co-authored-by: Sanjay Rai <sanrai@Sanjays-MacBook-Air.local>
…etadata anchor value (adobecom#3779)

* MWPW-164462: Add mep-id section-metadata property

* MWPW-164462: Use anchor instead of mep-id

* MWPW-164462: Rename funtion

* Update libs/features/personalization/personalization.js

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>

* MWPW-164462: Replace whitespace

* MWPW-164462: Add regex to the replaceAll

---------

Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com>
)

* Adding onReady and onError callback for standalone footer

* Code fix

* Changing footer css import to non blocking
* MWPW-167748 Fix focus in georouting modal with tabs

* restrict to only locale modal
* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* Trigger Build

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

* MWPW-167306 [Plans] Quantity Selector & Badge

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
…dobecom#3800)

* MWPW-169163 Re-enable broken psnlz tab preselecting function on US mini-plans pages

* MWPW-169163 Re-enable broken psnlz tab preselecting function on US mini-plans pages

* Trigger Build

---------

Co-authored-by: Bozo Jovicic <bozo@hitthecode.com>
* Add values for event95

* Fix failing test case

* Remove spaces

* Minimal Impact: Add extra key for  other features

* Minimal Impact: change function name
* [MWPW-168691] cta shrink fix

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] update

* [MWPW-168691] updated solution

* Revert "[MWPW-168691]"

This reverts commit a70f9ca.

Revert "[MWPW-168691] update"

This reverts commit 6aac2bc.

Revert "[MWPW-168691] update"

This reverts commit c0c6a34.

Revert "[MWPW-168691] update"

This reverts commit 017edf0.

Revert "[MWPW-168691] update"

This reverts commit 219e5fd.

Revert "[MWPW-168691] update"

This reverts commit a7df2b5.

Revert "[MWPW-168691] update"

This reverts commit 299a7d7.

Revert "[MWPW-168691] update"

This reverts commit 6709515.

Revert "[MWPW-168691] cta shrink fix"

This reverts commit c90eea6.

* MWPW-168691: Prevent cta jp word wrap on large screens

* MWPW-168691: Fix notification jp cta

* MWPW-168691: Hide wbr cta for tablet and desktop

---------

Co-authored-by: Ratko Zagorac <ratkozagorac@gmail.com>
* Adding countryCode config to UNav

* Updating countryCode for uk

* Updating for upperCase

* Passing countryCode according to MAS mapping for UCv3 cart

---------

Co-authored-by: Snehal Sonawane <sonawane@snehals-mbp.corp.adobe.com>
Co-authored-by: Snehal Sonawane <sonawane@Snehals-MacBook-Pro.local>
Made georouting and globalnavigation non blocking
* Lnav title text overflow support

* Fix for chevron icon top position

* Adding white space break for localnav menus

* Adding white space break for localnav menus

* Adding white space break for localnav list menus

* Inclufing white spaces to non menu items
…/main--federal--adobecom.aem.live/federal (adobecom#3813)

* on prod federal content for the standalone gnav and footer needs to come from

* handled situations where we're stage and when we're neither stage nor prod
…dobecom#3789)

* truly remove elements, even in preview

* unit test update

* fix for MWPW-169416, new remove action in MEP

* lint clean-up

---------

Co-authored-by: John Pratt <jpratt@adobe.com>
…le error (adobecom#3630)

* updated an svg inside a url() in the globalnav css to have data:image/svg+xml;utf8 inorder to prevent a console error

* changed a ; to a ,

* Removed the svg as it was unnecessary
@aem-code-sync
Copy link

aem-code-sync bot commented Mar 18, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Comment on lines +63 to +66
content.innerHTML = `<sp-theme system="light" color="light" scale="medium" dir="ltr">
<sp-progress-circle label="progress circle" indeterminate="" size="l" dir="ltr" role="progressbar" aria-label="progress circle"></sp-progress-circle>
</sp-theme>
<iframe src="${iframeUrl}" title="${modalType === MODAL_TYPE_3_IN_1.CRM ? 'Single App' : modalType}" frameborder="0" marginwidth="0" marginheight="0" allowfullscreen="true" loading="lazy" class="loading" style="height: 100%;"></iframe>`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.

Copilot Autofix

AI 12 months ago

To fix the problem, we need to ensure that the modalType variable is properly sanitized before being used in the innerHTML assignment. This can be achieved by using a function that escapes any potentially dangerous characters in the modalType string. We can use a well-known library like DOMPurify to sanitize the input.

  1. Import the DOMPurify library.
  2. Use DOMPurify.sanitize to sanitize the modalType variable before using it in the innerHTML assignment.
Suggested changeset 2
libs/blocks/merch/three-in-one.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/blocks/merch/three-in-one.js b/libs/blocks/merch/three-in-one.js
--- a/libs/blocks/merch/three-in-one.js
+++ b/libs/blocks/merch/three-in-one.js
@@ -3,2 +3,3 @@
 import { MODAL_TYPE_3_IN_1 } from '../../deps/mas/mas.js';
+import DOMPurify from 'dompurify';
 import '../../features/spectrum-web-components/dist/theme.js';
@@ -65,3 +66,3 @@
   </sp-theme>
-  <iframe src="${iframeUrl}" title="${modalType === MODAL_TYPE_3_IN_1.CRM ? 'Single App' : modalType}" frameborder="0" marginwidth="0" marginheight="0" allowfullscreen="true" loading="lazy" class="loading" style="height: 100%;"></iframe>`;
+  <iframe src="${iframeUrl}" title="${modalType === MODAL_TYPE_3_IN_1.CRM ? 'Single App' : DOMPurify.sanitize(modalType)}" frameborder="0" marginwidth="0" marginheight="0" allowfullscreen="true" loading="lazy" class="loading" style="height: 100%;"></iframe>`;
   return content;
EOF
@@ -3,2 +3,3 @@
import { MODAL_TYPE_3_IN_1 } from '../../deps/mas/mas.js';
import DOMPurify from 'dompurify';
import '../../features/spectrum-web-components/dist/theme.js';
@@ -65,3 +66,3 @@
</sp-theme>
<iframe src="${iframeUrl}" title="${modalType === MODAL_TYPE_3_IN_1.CRM ? 'Single App' : modalType}" frameborder="0" marginwidth="0" marginheight="0" allowfullscreen="true" loading="lazy" class="loading" style="height: 100%;"></iframe>`;
<iframe src="${iframeUrl}" title="${modalType === MODAL_TYPE_3_IN_1.CRM ? 'Single App' : DOMPurify.sanitize(modalType)}" frameborder="0" marginwidth="0" marginheight="0" allowfullscreen="true" loading="lazy" class="loading" style="height: 100%;"></iframe>`;
return content;
package.json
Outside changed files

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -35,3 +35,4 @@
     "htm": "^3.1.1",
-    "preact": "^10.11.0"
+    "preact": "^10.11.0",
+    "dompurify": "^3.2.4"
   },
EOF
@@ -35,3 +35,4 @@
"htm": "^3.1.1",
"preact": "^10.11.0"
"preact": "^10.11.0",
"dompurify": "^3.2.4"
},
This fix introduces these dependencies
Package Version Security advisories
dompurify (npm) 3.2.4 None
Copilot is powered by AI and may make mistakes. Always verify output.

</sp-theme>
</main>
<script type="module">

Check failure

Code scanning / CodeQL

DOM text reinterpreted as HTML High documentation

DOM text
is reinterpreted as HTML without escaping meta-characters.

Copilot Autofix

AI 12 months ago

To fix the problem, we need to ensure that the text content is properly escaped before being inserted into the HTML. This can be achieved by creating a text node and appending it to the container, which ensures that any special characters are properly escaped.

  • Replace the direct insertion of el.textContent into the HTML with a method that safely escapes the text content.
  • Specifically, create a text node for the content and append it to the container.
Suggested changeset 1
libs/features/mas/docs/checkout-button.html

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/features/mas/docs/checkout-button.html b/libs/features/mas/docs/checkout-button.html
--- a/libs/features/mas/docs/checkout-button.html
+++ b/libs/features/mas/docs/checkout-button.html
@@ -349,3 +349,7 @@
       targetContainer.classList.toggle('light', el.classList.contains('light'));
-      targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;
+      const demoContainer = document.createElement('div');
+      demoContainer.className = 'demo-container';
+      demoContainer.textContent = el.textContent;
+      targetContainer.innerHTML = '<h4>Demo: </h4>';
+      targetContainer.appendChild(demoContainer);
       el.parentElement.after(targetContainer);
EOF
@@ -349,3 +349,7 @@
targetContainer.classList.toggle('light', el.classList.contains('light'));
targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;
const demoContainer = document.createElement('div');
demoContainer.className = 'demo-container';
demoContainer.textContent = el.textContent;
targetContainer.innerHTML = '<h4>Demo: </h4>';
targetContainer.appendChild(demoContainer);
el.parentElement.after(targetContainer);
Copilot is powered by AI and may make mistakes. Always verify output.
document.querySelectorAll('code.demo').forEach(el => {
const targetContainer = document.createElement('div');
targetContainer.classList.toggle('light', el.classList.contains('light'));
targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;

Check failure

Code scanning / CodeQL

DOM text reinterpreted as HTML High documentation

DOM text
is reinterpreted as HTML without escaping meta-characters.

Copilot Autofix

AI 12 months ago

To fix the problem, we need to ensure that any text content inserted into the DOM is properly escaped to prevent XSS attacks. This can be achieved by using a text node instead of setting innerHTML directly. By creating a text node, we ensure that any special characters in the text content are properly escaped.

  • Replace the use of innerHTML with a method that safely inserts text content.
  • Specifically, create a text node for the text content and append it to the target container.
Suggested changeset 1
libs/features/mas/docs/plans.html

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/features/mas/docs/plans.html b/libs/features/mas/docs/plans.html
--- a/libs/features/mas/docs/plans.html
+++ b/libs/features/mas/docs/plans.html
@@ -64,3 +64,9 @@
       targetContainer.classList.toggle('light', el.classList.contains('light'));
-      targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;
+      const demoTitle = document.createElement('h4');
+      demoTitle.textContent = 'Demo: ';
+      const demoContainer = document.createElement('div');
+      demoContainer.className = 'demo-container';
+      demoContainer.textContent = el.textContent;
+      targetContainer.appendChild(demoTitle);
+      targetContainer.appendChild(demoContainer);
       el.parentElement.after(targetContainer);
EOF
@@ -64,3 +64,9 @@
targetContainer.classList.toggle('light', el.classList.contains('light'));
targetContainer.innerHTML = `<h4>Demo: </h4><div class="demo-container">${el.textContent}</div>`;
const demoTitle = document.createElement('h4');
demoTitle.textContent = 'Demo: ';
const demoContainer = document.createElement('div');
demoContainer.className = 'demo-container';
demoContainer.textContent = el.textContent;
targetContainer.appendChild(demoTitle);
targetContainer.appendChild(demoContainer);
el.parentElement.after(targetContainer);
Copilot is powered by AI and may make mistakes. Always verify output.
wcsOsi,
extraOptions,
});
if (innerHTML)

Check warning

Code scanning / CodeQL

Unsafe HTML constructed from library input Medium

This HTML construction which depends on
library input
might later allow
cross-site scripting
.
This HTML construction which depends on
library input
might later allow
cross-site scripting
.

Copilot Autofix

AI 12 months ago

To fix the problem, we need to ensure that the innerHTML parameter is sanitized before being inserted into the DOM. This can be achieved by using a library like DOMPurify to sanitize the input. This approach will allow us to maintain the existing functionality while ensuring that any potentially unsafe HTML is cleaned before being used.

Suggested changeset 2
libs/features/mas/src/checkout-mixin.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/features/mas/src/checkout-mixin.js b/libs/features/mas/src/checkout-mixin.js
--- a/libs/features/mas/src/checkout-mixin.js
+++ b/libs/features/mas/src/checkout-mixin.js
@@ -8,2 +8,3 @@
 import { MODAL_TYPE_3_IN_1 } from '../src/constants.js';
+import DOMPurify from 'dompurify';
 
@@ -44,3 +45,3 @@
     if (innerHTML)
-        element.innerHTML = `<span style="pointer-events: none;">${innerHTML}</span>`;
+        element.innerHTML = `<span style="pointer-events: none;">${DOMPurify.sanitize(innerHTML)}</span>`;
     return element;
@@ -54,3 +55,2 @@
         masElement = new MasElement(this);
-
         attributeChangedCallback(name, oldValue, value) {
EOF
@@ -8,2 +8,3 @@
import { MODAL_TYPE_3_IN_1 } from '../src/constants.js';
import DOMPurify from 'dompurify';

@@ -44,3 +45,3 @@
if (innerHTML)
element.innerHTML = `<span style="pointer-events: none;">${innerHTML}</span>`;
element.innerHTML = `<span style="pointer-events: none;">${DOMPurify.sanitize(innerHTML)}</span>`;
return element;
@@ -54,3 +55,2 @@
masElement = new MasElement(this);

attributeChangedCallback(name, oldValue, value) {
libs/features/mas/package.json
Outside changed files

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/features/mas/package.json b/libs/features/mas/package.json
--- a/libs/features/mas/package.json
+++ b/libs/features/mas/package.json
@@ -14,73 +14,75 @@
     },
-    "dependencies": {},
-    "devDependencies": {
-        "@dexter/tacocat-core": "file:./internal/tacocat-core-1.13.1.tgz",
-        "@esm-bundle/chai-as-promised": "7.1.1",
-        "@esm-bundle/chai": "4.3.4-fix.0",
-        "@pandora/data-models-odm": "file:./internal/data-models-odm-0.5.4.tgz",
-        "@pandora/data-source-utils": "file:./internal/data-source-utils-0.3.1.tgz",
-        "@pandora/fetch": "file:./internal/fetch-1.3.4.tgz",
-        "@pandora/logger": "file:./internal/logger-1.3.0.tgz",
-        "@spectrum-css/button": "^13.5.0",
-        "@spectrum-css/link": "^5.2.0",
-        "@spectrum-css/page": "^8.2.0",
-        "@spectrum-css/tokens": "^14.6.0",
-        "@spectrum-css/typography": "^6.2.0",
-        "@spectrum-web-components/action-button": "^0.46.0",
-        "@spectrum-web-components/action-menu": "^0.46.0",
-        "@spectrum-web-components/alert-dialog": "^0.46.0",
-        "@spectrum-web-components/base": "^0.46.0",
-        "@spectrum-web-components/button-group": "^0.46.0",
-        "@spectrum-web-components/button": "^0.46.0",
-        "@spectrum-web-components/checkbox": "^0.46.0",
-        "@spectrum-web-components/close-button": "^0.46.0",
-        "@spectrum-web-components/dialog": "^0.46.0",
-        "@spectrum-web-components/divider": "^0.46.0",
-        "@spectrum-web-components/field-label": "^0.46.0",
-        "@spectrum-web-components/help-text": "^0.46.0",
-        "@spectrum-web-components/icon": "^0.46.0",
-        "@spectrum-web-components/icons-ui": "^0.46.0",
-        "@spectrum-web-components/icons-workflow": "^0.46.0",
-        "@spectrum-web-components/icons": "^0.46.0",
-        "@spectrum-web-components/link": "^0.46.0",
-        "@spectrum-web-components/menu": "^0.46.0",
-        "@spectrum-web-components/modal": "^0.46.0",
-        "@spectrum-web-components/overlay": "^0.46.0",
-        "@spectrum-web-components/picker": "^0.46.0",
-        "@spectrum-web-components/popover": "^0.46.0",
-        "@spectrum-web-components/progress-circle": "^0.46.0",
-        "@spectrum-web-components/radio": "^0.46.0",
-        "@spectrum-web-components/reactive-controllers": "^0.46.0",
-        "@spectrum-web-components/search": "^0.46.0",
-        "@spectrum-web-components/shared": "^0.46.0",
-        "@spectrum-web-components/sidenav": "^0.46.0",
-        "@spectrum-web-components/split-button": "^0.46.0",
-        "@spectrum-web-components/styles": "^0.46.0",
-        "@spectrum-web-components/tabs": "^0.46.0",
-        "@spectrum-web-components/textfield": "^0.46.0",
-        "@spectrum-web-components/theme": "^0.46.0",
-        "@spectrum-web-components/toast": "^0.46.0",
-        "@spectrum-web-components/tooltip": "^0.46.0",
-        "@spectrum-web-components/tray": "^0.46.0",
-        "@spectrum-web-components/underlay": "^0.46.0",
-        "@types/chai-as-promised": "7.1.5",
-        "@types/sinon": "10.0.15",
-        "@web/dev-server-import-maps": "^0.2.1",
-        "@web/test-runner-commands": "^0.9.0",
-        "@web/test-runner": "^0.18.2",
-        "esbuild": "^0.24.0",
-        "eslint-config-prettier": "^9.1.0",
-        "eslint-plugin-prettier": "^5.1.3",
-        "eslint": "^9.5.0",
-        "husky": "^9.0.11",
-        "intl-messageformat": "^9.9.0",
-        "lit": "^2.8.0",
-        "markdown-it-anchor": "^9.2.0",
-        "markdown-it-attrs": "^4.2.0",
-        "markdown-it-container": "^4.0.0",
-        "markdown-it-highlightjs": "^4.2.0",
-        "markdown-it": "^14.1.0",
-        "prettier": "^3.3.2",
-        "sinon": "13.0.1"
-    }
+    "dependencies": {
+    "dompurify": "^3.2.4"
+  },
+  "devDependencies": {
+    "@dexter/tacocat-core": "file:./internal/tacocat-core-1.13.1.tgz",
+    "@esm-bundle/chai-as-promised": "7.1.1",
+    "@esm-bundle/chai": "4.3.4-fix.0",
+    "@pandora/data-models-odm": "file:./internal/data-models-odm-0.5.4.tgz",
+    "@pandora/data-source-utils": "file:./internal/data-source-utils-0.3.1.tgz",
+    "@pandora/fetch": "file:./internal/fetch-1.3.4.tgz",
+    "@pandora/logger": "file:./internal/logger-1.3.0.tgz",
+    "@spectrum-css/button": "^13.5.0",
+    "@spectrum-css/link": "^5.2.0",
+    "@spectrum-css/page": "^8.2.0",
+    "@spectrum-css/tokens": "^14.6.0",
+    "@spectrum-css/typography": "^6.2.0",
+    "@spectrum-web-components/action-button": "^0.46.0",
+    "@spectrum-web-components/action-menu": "^0.46.0",
+    "@spectrum-web-components/alert-dialog": "^0.46.0",
+    "@spectrum-web-components/base": "^0.46.0",
+    "@spectrum-web-components/button-group": "^0.46.0",
+    "@spectrum-web-components/button": "^0.46.0",
+    "@spectrum-web-components/checkbox": "^0.46.0",
+    "@spectrum-web-components/close-button": "^0.46.0",
+    "@spectrum-web-components/dialog": "^0.46.0",
+    "@spectrum-web-components/divider": "^0.46.0",
+    "@spectrum-web-components/field-label": "^0.46.0",
+    "@spectrum-web-components/help-text": "^0.46.0",
+    "@spectrum-web-components/icon": "^0.46.0",
+    "@spectrum-web-components/icons-ui": "^0.46.0",
+    "@spectrum-web-components/icons-workflow": "^0.46.0",
+    "@spectrum-web-components/icons": "^0.46.0",
+    "@spectrum-web-components/link": "^0.46.0",
+    "@spectrum-web-components/menu": "^0.46.0",
+    "@spectrum-web-components/modal": "^0.46.0",
+    "@spectrum-web-components/overlay": "^0.46.0",
+    "@spectrum-web-components/picker": "^0.46.0",
+    "@spectrum-web-components/popover": "^0.46.0",
+    "@spectrum-web-components/progress-circle": "^0.46.0",
+    "@spectrum-web-components/radio": "^0.46.0",
+    "@spectrum-web-components/reactive-controllers": "^0.46.0",
+    "@spectrum-web-components/search": "^0.46.0",
+    "@spectrum-web-components/shared": "^0.46.0",
+    "@spectrum-web-components/sidenav": "^0.46.0",
+    "@spectrum-web-components/split-button": "^0.46.0",
+    "@spectrum-web-components/styles": "^0.46.0",
+    "@spectrum-web-components/tabs": "^0.46.0",
+    "@spectrum-web-components/textfield": "^0.46.0",
+    "@spectrum-web-components/theme": "^0.46.0",
+    "@spectrum-web-components/toast": "^0.46.0",
+    "@spectrum-web-components/tooltip": "^0.46.0",
+    "@spectrum-web-components/tray": "^0.46.0",
+    "@spectrum-web-components/underlay": "^0.46.0",
+    "@types/chai-as-promised": "7.1.5",
+    "@types/sinon": "10.0.15",
+    "@web/dev-server-import-maps": "^0.2.1",
+    "@web/test-runner-commands": "^0.9.0",
+    "@web/test-runner": "^0.18.2",
+    "esbuild": "^0.24.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-prettier": "^5.1.3",
+    "eslint": "^9.5.0",
+    "husky": "^9.0.11",
+    "intl-messageformat": "^9.9.0",
+    "lit": "^2.8.0",
+    "markdown-it-anchor": "^9.2.0",
+    "markdown-it-attrs": "^4.2.0",
+    "markdown-it-container": "^4.0.0",
+    "markdown-it-highlightjs": "^4.2.0",
+    "markdown-it": "^14.1.0",
+    "prettier": "^3.3.2",
+    "sinon": "13.0.1"
+  }
 }
EOF
This fix introduces these dependencies
Package Version Security advisories
dompurify (npm) 3.2.4 None
Copilot is powered by AI and may make mistakes. Always verify output.
el.log.error('test error');
const [, url] = calls[0].open.lastCall.args;
expect(
/https\:\/\/www.stage.adobe.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test(

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'adobe.com', so it might match more hosts than expected.

Copilot Autofix

AI 12 months ago

To fix the problem, we need to escape the . meta-character in the regular expression to ensure that it matches only the literal . character. This will prevent unintended matches and ensure that the regular expression only matches the intended domain.

  • Locate the regular expression on line 157 in the file libs/features/mas/test/mas-commerce-service.test.js.
  • Modify the regular expression to escape the . character before adobe.com.
Suggested changeset 1
libs/features/mas/test/mas-commerce-service.test.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/libs/features/mas/test/mas-commerce-service.test.js b/libs/features/mas/test/mas-commerce-service.test.js
--- a/libs/features/mas/test/mas-commerce-service.test.js
+++ b/libs/features/mas/test/mas-commerce-service.test.js
@@ -156,3 +156,3 @@
                 expect(
-                    /https\:\/\/www.stage.adobe.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test(
+                    /https\:\/\/www\.stage\.adobe\.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test(
                         url,
EOF
@@ -156,3 +156,3 @@
expect(
/https\:\/\/www.stage.adobe.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test(
/https\:\/\/www\.stage\.adobe\.com\/lana\/ll\?m=test%20error.*c=merch-at-scale&s=100&t=e&tags=ccd/.test(
url,
Copilot is powered by AI and may make mistakes. Always verify output.
});

const result = await getFilesToPromote({
accessToken: 'token',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "token" is used as
authorization header
.

it('should return files for paths ending with .json', async () => {
const result = await getFilesToPromote({
accessToken: 'token',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "token" is used as
authorization header
.

it('should return html files for paths not ending with slash or .json', async () => {
const result = await getFilesToPromote({
accessToken: 'token',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "token" is used as
authorization header
.

it('should handle empty paths array', async () => {
const result = await getFilesToPromote({
accessToken: 'token',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "token" is used as
authorization header
.
requestHandlerStub.resolves({ ok: false });

const result = await getFilesToPromote({
accessToken: 'token',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "token" is used as
authorization header
.
@aem-code-sync aem-code-sync bot temporarily deployed to stage March 18, 2025 13:12 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to stage March 18, 2025 13:14 Inactive
@mokimo mokimo closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.