Skip to content

Add Skyneticlabs testnet validator info (ID 230)#855

Merged
johnmarcou merged 3 commits intomonad-developers:mainfrom
Skyneticlabs:main
Mar 3, 2026
Merged

Add Skyneticlabs testnet validator info (ID 230)#855
johnmarcou merged 3 commits intomonad-developers:mainfrom
Skyneticlabs:main

Conversation

@Skyneticlabs
Copy link
Contributor

Add Skyneticlabs testnet validator info (ID 230)

@greptile-apps
Copy link

greptile-apps bot commented Mar 3, 2026

Greptile Summary

This PR adds a single JSON file registering Skyneticlabs as a testnet validator (ID 230), following the standard directory format used by all other validators in this repository.

  • File placement: Correctly placed in the testnet/ directory with the filename matching the secp field value (034799aeb98c40f05cfb068aa5ed17e72646932dce1c567aef43ee9873265a204e.json) ✓
  • Schema compliance: All required fields (id, name, secp, bls, website, description, logo, x) are present with the correct types, matching the example schema ✓
  • Key formats: secp is 66 hex characters (33-byte compressed SECP256k1), bls is 96 hex characters (48-byte compressed BLS12-381 G1) — consistent with all other validator entries ✓
  • ID uniqueness: ID 230 is not used by any other existing validator entry ✓
  • Logo URL: Hosted at raw.githubusercontent.com over HTTPS; the CI validate.py script will confirm it returns a valid image ✓
  • On-chain verification: The CI workflow (check.yaml) runs scripts/validate.py against the changed file, which will verify that the secp and bls keys match the on-chain registered values for validator ID 230 before the PR can be merged ✓

Confidence Score: 5/5

  • This PR is safe to merge once the automated CI checks pass, as the file is correctly formatted and consistent with all existing validator entries.
  • The change is a single, well-structured JSON file that correctly follows the established schema. All key lengths are correct, the filename matches the secp key, the ID is unique, all required fields are present, and all URLs use HTTPS. The CI workflow provides additional safety by verifying on-chain key matching and logo URL validity before merge.
  • No files require special attention.

Sequence Diagram

sequenceDiagram
    participant Author as Skyneticlabs (Author)
    participant PR as Pull Request
    participant CI as GitHub Actions (check.yaml)
    participant Script as validate.py
    participant Chain as Monad Testnet RPC
    participant Logo as raw.githubusercontent.com

    Author->>PR: Add testnet/034799...4e.json
    PR->>CI: Trigger on pull_request (testnet/*.json changed)
    CI->>Script: python scripts/validate.py testnet/034799...4e.json
    Script->>Script: Check JSON is valid ✓
    Script->>Script: Check schema fields match example ✓
    Script->>Script: Check name is non-empty ✓
    Script->>Logo: GET https://raw.githubusercontent.com/.../Skyneticlabs.jpg
    Logo-->>Script: 200 OK, Content-Type: image/jpeg
    Script->>Chain: call_getter(w3, "get_validator", contract, id=230)
    Chain-->>Script: secp=034799...4e, bls=892211...e8
    Script->>Script: Assert local secp == chain secp ✓
    Script->>Script: Assert local bls == chain bls ✓
    Script->>Script: Assert filename == secp + ".json" ✓
    Script-->>CI: 🎉 Validation successful!
    CI-->>PR: Checks pass → ready to merge
Loading

Last reviewed commit: 6363f1e

@johnmarcou johnmarcou merged commit e566690 into monad-developers:main Mar 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants