Skip to content

feat: add validator 187 on mainnet#857

Merged
johnmarcou merged 2 commits intomonad-developers:mainfrom
Hazzzzzzzzze:add-validator-187
Mar 4, 2026
Merged

feat: add validator 187 on mainnet#857
johnmarcou merged 2 commits intomonad-developers:mainfrom
Hazzzzzzzzze:add-validator-187

Conversation

@Hazzzzzzzzze
Copy link
Contributor

No description provided.

@Hazzzzzzzzze Hazzzzzzzzze requested a review from a team as a code owner March 4, 2026 09:44
@greptile-apps
Copy link

greptile-apps bot commented Mar 4, 2026

Greptile Summary

This PR adds a new mainnet validator entry for Kiln (validator id 187) by submitting a JSON metadata file. The file is mostly well-formed, but it is missing the required x field, which will cause the repository's CI schema validation script (scripts/validate.py) to fail and block merging.

The x (Twitter/X profile URL) field is defined in the example schema and is enforced by the check_schema() function in the validation script — its absence will produce ❌ Missing field: 'x' and a non-zero exit code. All other fields (id, name, secp, bls, website, description, logo) are present and correctly typed, and the filename correctly matches the secp key value as required.

Confidence Score: 2/5

  • Not safe to merge — the missing x field will cause CI validation to fail.
  • The file structure is otherwise correct, but the missing required x field is a hard blocker: the validation script's check_schema() function compares against the example schema and exits with a non-zero code when any field is absent, so the GitHub Actions check will fail and prevent merging.
  • mainnet/0389f4d29ac3ddbd010f2ba6874c29695ec187ce32d9f8941ecf1a01642cadaf52.json — Missing required x field

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Add validator JSON file] --> B[CI: scripts/validate.py]
    B --> C{JSON loadable?}
    C -- No --> FAIL1[❌ Invalid JSON]
    C -- Yes --> D{check_schema\nAll 8 fields present?\nid, name, secp, bls,\nwebsite, description,\nlogo, x}
    D -- Missing 'x' field --> FAIL2[❌ Schema check failed\nMissing field: 'x']
    D -- Pass --> E{name non-empty?}
    E -- Fail --> FAIL3[❌ Invalid name]
    E -- Pass --> F{Logo URL valid\nHTTPS + returns image?}
    F -- Fail --> FAIL4[❌ Logo check failed]
    F -- Pass --> G{On-chain SECP\n& BLS match?}
    G -- Mismatch --> FAIL5[❌ Key mismatch]
    G -- Match --> H{Filename == secp.json?}
    H -- Mismatch --> FAIL6[❌ Filename mismatch]
    H -- Match --> SUCCESS[🎉 Validation successful]

    style FAIL2 fill:#ff4444,color:#fff
    style FAIL1 fill:#ff8888,color:#fff
    style FAIL3 fill:#ff8888,color:#fff
    style FAIL4 fill:#ff8888,color:#fff
    style FAIL5 fill:#ff8888,color:#fff
    style FAIL6 fill:#ff8888,color:#fff
    style SUCCESS fill:#44bb44,color:#fff
    style D fill:#ffcccc
Loading

Last reviewed commit: 6de6b02

@johnmarcou johnmarcou merged commit 349ac2f into monad-developers:main Mar 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants