Skip to content

Update StakeAngle validator info due to keys replacement#858

Open
Cryptoperchik wants to merge 3 commits intomonad-developers:mainfrom
Cryptoperchik:main
Open

Update StakeAngle validator info due to keys replacement#858
Cryptoperchik wants to merge 3 commits intomonad-developers:mainfrom
Cryptoperchik:main

Conversation

@Cryptoperchik
Copy link
Contributor

No description provided.

@Cryptoperchik Cryptoperchik requested a review from a team as a code owner March 6, 2026 03:08
@greptile-apps
Copy link

greptile-apps bot commented Mar 6, 2026

Greptile Summary

This PR performs a validator key rotation for StakeAngle on the testnet: the old entry (secp key 03c14560..., ID 45) is deleted and replaced with a new entry (secp key 0240f2fb..., ID 232) reflecting the validator's new key pair.

Key observations:

  • The new filename correctly matches the updated secp field value (0240f2fb...11ce), which is the expected convention for this repository.
  • The new secp key is properly formatted: starts with 02 (compressed public key prefix) and is 66 hex characters (33 bytes) ✅
  • The new BLS key is properly formatted: 96 hex characters (48 bytes), consistent with BLS12-381 compressed public keys and other entries in the repo ✅
  • ID 232 is unique across all testnet validator files — no collision detected ✅
  • Non-key metadata (name, website, description, logo, x) is preserved unchanged ✅
  • The validator's numeric ID changed from 45 → 232. ID 45 is now unassigned. This is worth noting: if any downstream systems track validators by their numeric ID (rather than by their secp key), this assignment of a new ID could require coordination. Based on recent PRs in this repo, this pattern (new ID on key rotation) appears to be intentional.

Confidence Score: 4/5

  • Safe to merge — the key rotation is correctly structured, all cryptographic key formats are valid, and no ID conflicts exist.
  • Both the secp and BLS keys are properly formatted and match the expected lengths. The filename correctly reflects the new secp key. The new ID (232) is unique in the repo. The only minor point is the ID change from 45 to 232, which may require attention if downstream consumers identify validators by numeric ID, but appears intentional given the repo's conventions for key rotations.
  • No files require special attention beyond confirming the new validator keys are operationally registered on-chain.

Important Files Changed

Filename Overview
testnet/0240f2fb292dd0f600499d35b69202ae99efaf2ce9733fbd3e4066c8d1842211ce.json StakeAngle validator info updated with new secp/BLS keys and a new ID (232); filename correctly matches the updated secp key; key lengths and formats are valid; old ID 45 is now unassigned.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Old Validator Entry\nFile: 03c14560....json\nID: 45] -->|Keys Replaced| B{Key Rotation}
    B -->|Delete old file| C[File Removed\n03c14560....json]
    B -->|Create new file| D[New Validator Entry\nFile: 0240f2fb....json\nID: 232]
    D --> E[secp: 0240f2fb...11ce\n✅ 66 hex chars, prefix 02]
    D --> F[bls: 8c3a905e...b07e\n✅ 96 hex chars]
    D --> G[name / website / description\nlogo / x unchanged]
Loading

Last reviewed commit: a878e9b

Copy link
Contributor

@johnmarcou johnmarcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please avoid deleting the old record, and only create a new one?
We need to keep mapping between the repository and the validator IDs registered on the staking contract on chain. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants