Skip to content

Conversation

@gw31415
Copy link
Contributor

@gw31415 gw31415 commented Aug 31, 2025

Thank you very much for creating such a convenient plugin.

Issue

  • plugin/dial.lua is not being loaded.
    • This is the reason why mappings like <Plug>(dial-increment) do not work.

Cause

vim.fn.exists "g:loaded_dial" always returns either 0 or 1.
However, in Lua both 0 and 1 are evaluated as truthy, so the if condition always evaluates to true.
As a result, plugin/dial.lua exits early.

Concern

From a quick search from the issues, it seems this issue has not been reported. Why might that be?

Nevertheless, since I believe this is at least unintended behavior, I have submitted a PR.
Thank you for your consideration.

@monaqa monaqa added the bug Something isn't working label Aug 31, 2025
@monaqa
Copy link
Owner

monaqa commented Aug 31, 2025

Thank you so much! My fault.
There was a bug in #114 which I implemented.
The reason no one reported it is because it was only merged yesterday.

@monaqa monaqa merged commit f0404ec into monaqa:master Aug 31, 2025
2 checks passed
@gw31415 gw31415 deleted the fix/check-var-loaded-lua branch August 31, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants