fix: Fix the operation to check for the existence of global var loaded_dial
#118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for creating such a convenient plugin.
Issue
plugin/dial.luais not being loaded.<Plug>(dial-increment)do not work.Cause
vim.fn.exists "g:loaded_dial"always returns either0or1.However, in Lua both
0and1are evaluated as truthy, so the if condition always evaluates to true.As a result,
plugin/dial.luaexits early.Concern
From a quick search from the issues, it seems this issue has not been reported. Why might that be?
Nevertheless, since I believe this is at least unintended behavior, I have submitted a PR.
Thank you for your consideration.