-
Notifications
You must be signed in to change notification settings - Fork 23
New augend - English shortform ordinals #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Was unable to have multiple ordinals per line, and was unable to have ordinals on the same line after some text similar to `5thousand` or `3rdev` before this fix was implemented
|
Thank you for the excellent PR!
What do you think? |
|
I agree to both your points. In fact, I even tried to implement digit delimiters into the new augend but failed to do so and that resulted in the simplified implementation I submitted in this PR. This also somewhat explains my reasoning behind making it an alias under I truly appreciate all your input, as I find multiple perspectives extremely helpful. In the meantime, I shall convert this PR to a draft until the bulk of the refactoring is complete. |
Refactor ordinal augend from a `misc` alias to its own augend type BREAKING CHANGE: creation of new augend type
|
I have successfully managed to refactor the augend out of Additionally, I have added The only other things I feel are missing are digit delimiters and proper documentation regarding the new augend, but I feel like my doc-writing capabilities aren't quite up to snuff. |
Add the ability to increment and decrement English shortform ordinals like
7th0th-st,-nd, and-rdsuffixes-1st,-2nd,-3rd, ...)