Load payments in parallel using std::thread::scope #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This significantly improves startup time for network-backed stores like VSS, where sequential reads incur per-key network latency.
amackillop
reviewed
Jan 2, 2026
| }) | ||
| .and_then(|r| r) | ||
| }) | ||
| .collect() |
There was a problem hiding this comment.
From the docs:
All threads spawned within the scope that haven’t been manually joined will be automatically joined before this function returns.
Does that mean we do not need to manually join here? Can errors be mapped on line 259?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves startup time for network-backed stores like VSS, where sequential reads incur per-key network latency
also created here lightningdevkit#738
this version does not use StoreSync