chore(compass-indexes): align default index names with cloud COMPASS-9257#7782
chore(compass-indexes): align default index names with cloud COMPASS-9257#7782johnjackweir merged 4 commits intomainfrom
Conversation
johnjackweir
changed the title
johnjackweir
changed the title
| setIndexDefinition(ATLAS_VECTOR_SEARCH_TEMPLATE.snippet); | ||
| onChangeTemplate(ATLAS_VECTOR_SEARCH_TEMPLATE); | ||
|
|
||
| if (indexName === 'default') { |
There was a problem hiding this comment.
note that this component is used for both create & update. update doesn't show the option to switch types so we're good now - just to be safe we could add a check here to ensure we don't change the name in that case
There was a problem hiding this comment.
actually this whole code is probably useless in that case, so it should be a return at the top of the fn and also is a preexisting problem, feel free to ignore me :D
There was a problem hiding this comment.
That is a good thought 🤔
it's unclear to me what the intended behavior would to update the index type for an existing index. I feel like we might cause more confusion if we intentionally enabled the "changeIndexType" button but then had the onClick handler just silently fail, so I'm tempted to just leave it as is
There was a problem hiding this comment.
yeah I'm absolutely not proposing to enable it, I was just thinking what would happen if it did became enabled at some point. leaving it as it is is fine.
| setIndexDefinition(ATLAS_SEARCH_TEMPLATES[0].snippet); | ||
| onChangeTemplate(ATLAS_SEARCH_TEMPLATES[0]); | ||
|
|
||
| if (indexName === 'vector_index') { |
2 participants
Description
COMPASS-9257
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes