Skip to content

chore(e2e): use getters for default connections access instead of constant variables COMPASS-10308#7786

Open
gribnoysup wants to merge 1 commit intomainfrom
use-getter-functions-for-defeault-connections
Open

chore(e2e): use getters for default connections access instead of constant variables COMPASS-10308#7786
gribnoysup wants to merge 1 commit intomainfrom
use-getter-functions-for-defeault-connections

Conversation

@gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Feb 11, 2026

In the refactored Atlas Cloud tests we will be adding new connections (clusters) dynamically during the global "before" test configuration, this doens't work well with the current way we access these variables that are syncronously defined on the test run start. This patch is a small refactor to make sure that when we dynamically populate DEFAULT_CONNECTIONS, all other places can access up to date information about those

@gribnoysup gribnoysup requested a review from a team as a code owner February 11, 2026 16:28
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Feb 11, 2026
@gribnoysup gribnoysup changed the title chore(e2e): use getters for default connections access instead of constant variables chore(e2e): use getters for default connections access instead of constant variables COMPASS-10308 Feb 11, 2026
Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants