Open
Conversation
This script was broken in some bizarre ways -- for example, it assumed that "monorepo root" and "root" were a) different and b) located at a fixed relative path to the filename of the precommit script, or it assumed that the repository would always have a `.gitmodules` file -- that make it very unclear to me how these issues went unnoticed for as long as they did.
addaleax
commented
Feb 14, 2026
| const execFileAsync = promisify(execFile); | ||
|
|
||
| const monorepoRoot = path.resolve(__dirname, '..', '..'); | ||
| const repoRoot = path.resolve(monorepoRoot, '..'); |
Collaborator
Author
There was a problem hiding this comment.
^ I can't seem to make sense of why ../.. and ../../.. were chosen to be the "monorepo root" and "repo root", respectively – but this must have been intentional, right?
Collaborator
There was a problem hiding this comment.
I guess monorepo root is packages/ and root is the repo root? where .git is?
kmruiz
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script was broken in some bizarre ways -- for example, it assumed that "monorepo root" and "root" were a) different and b) located at a fixed relative path to the filename of the precommit script, or it assumed that the repository would always have a
.gitmodulesfile -- that make it very unclear to me how these issues went unnoticed for as long as they did.Description
Open Questions
Checklist