feat: add default sort order vscode extension setting VSCODE-742

[tculig]

Description

Ticket: https://jira.mongodb.org/browse/VSCODE-742

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[lerouxb]

Is there no better way than putting things on window to be passing default parameters to a redux reducer's slice?

[lerouxb]

Maybe there's a problem here that I can't spot, but surely you can do vscode.workspace.getConfiguration('mdb').get<SortValueKey>('defaultSortOrder') ?? 'default'); and pass it to createStore() as preloadedState?

You only need it by the time you pass store to the provider here https://github.com/tculig/vscode-tiho/blob/9a609299927f7206e967296622a246828786bf03/src/views/app.tsx#L23

[tculig]

this is inside the webview, it shouldn't have access to vscode.workspace, but let me double check..

[tculig]

yeah, it doesn't, can't run vscode.workspace.getConfiguration('mdb').get('defaultSortOrder') inside any of the webview code, including the redux store.

[lerouxb]

Is there no standard way to pass information to a webview? How do other extensions pass do this?

[tculig]

As far as I can research, if you want something to be available at load time, this is the only way. Alternative is to post a massage once the webview loads, but that is gonna be prone to race conditions, flicker, etc. It IS a somewhat established pattern according to ChatGPT, Claude Code and obscure StackOverflow questions: https://stackoverflow.com/questions/58326788/how-to-pass-parameters-into-a-script-in-a-vs-code-webview

[lerouxb]

If there is no better way and this is the best way to do it, can we at least leave a comment where we store things on the window object explaining why. Because I imagine anyone reading the code is going to find it surprising.

As a general rule if we resort to something weird, let's write a detailed comment explaining why.

[lerouxb]

I suppose we could have also not rendered anything until an initial message with the config arrives (some kind of isLoading state?), but admittedly at this point that's probably more work than it is worth.

[tculig]

in my experience, doing complex things in onLoad, especially for webviews, is fragile AF. The onLoad flag itself is pretty non-reliable