Skip to content

fix: don't actually treat this like a typescript editor#1244

Merged
lerouxb merged 1 commit intomainfrom
turn-off-intellisense
Feb 11, 2026
Merged

fix: don't actually treat this like a typescript editor#1244
lerouxb merged 1 commit intomainfrom
turn-off-intellisense

Conversation

@lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Feb 11, 2026

After #1240 monaco is now loading all its code (most notably a web worker) and started to think that a document like { name } is referencing some deprecated DOM variable..

This just turns off lots of things because this isn't actually a typescript editor.

Copilot AI review requested due to automatic review settings February 11, 2026 14:51
@lerouxb lerouxb requested a review from a team as a code owner February 11, 2026 14:51
monaco.typescript.typescriptDefaults.setCompilerOptions({
target: monaco.typescript.ScriptTarget.Latest,
allowNonTsExtensions: true,
noLib: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be the only relevant line in this block 🤷

@lerouxb lerouxb changed the title don't actually treat this like a typescript editor fix: don't actually treat this like a typescript editor Feb 11, 2026
@lerouxb lerouxb added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Feb 11, 2026
@lerouxb lerouxb requested a review from tculig February 11, 2026 15:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@lerouxb lerouxb merged commit 4ad6233 into main Feb 11, 2026
21 of 23 checks passed
@lerouxb lerouxb deleted the turn-off-intellisense branch February 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants