chore: adds tests for oidc in vscode - VSCODE-414#652
Merged
himanshusinghs merged 11 commits intomainfrom Jan 11, 2024
Merged
Conversation
Contributor
Author
|
Converting to draft since we might need to move the CI to evergreen. I will be looking into that. |
Contributor
Author
|
No need to move the CI to evergreen just yet. Fixed the issues that were there for our Github actions. |
himanshusinghs
changed the title
mcasimir
reviewed
Jan 10, 2024
src/test/suite/oidc.test.ts
Outdated
| await testConnectionController.getActiveDataService()?.count('x.y', {}); | ||
|
|
||
| // Minor pause | ||
| await new Promise((resolve) => setTimeout(resolve, 500)); |
Contributor
There was a problem hiding this comment.
Do we need to rely on this? Is there a different way that is not making the result subject to timing?
Contributor
Author
There was a problem hiding this comment.
Just addressed this in my recent commit.
Anemy
reviewed
Jan 10, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Couple smaller questions / thoughts. Nice tests!
Anemy
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we have added tests for OIDC feature that covers all the applicable cases covered by compass as well as a few scenarios specific to vscode.
These are not E2E tests unfortunately, that is still an exploratory work in this PR
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes