DOCSP-46497 & DOCSP-46233: Add historical and line item billing examples to Go SDK project#51
Conversation
cbullinger
changed the title
dacharyc
left a comment
dacharyc
left a comment
There was a problem hiding this comment.
This is a lot of work, and I'm very impressed with the thoroughness and handling you've done here! Only a couple of blocking comments related to the generated output project - it won't run as-is because there are some bits still hanging out from before you did the refactor. The rest of the comments are just Qs, kudos, and non-blocking nits.
We should probably also update the INTERNAL_README.md with the updated directory structure, similar to what you did in the README.md.
usage-examples/go/atlas-sdk-go/internal/billing/sku_classifier_test.go
Outdated
Show resolved
Hide resolved
| // NOTE: You can define a default global directory for all generated files by setting the ATLAS_DOWNLOADS_DIR environment variable. | ||
| func GenerateOutputPath(dir, prefix, extension string) (string, error) { | ||
| // If default download directory is set in .env, prepend it to the provided dir | ||
| defaultDir := os.Getenv("ATLAS_DOWNLOADS_DIR") |
There was a problem hiding this comment.
Nice - very thoughtful approach!
generated-usage-examples/go/atlas-sdk-go/project-copy/internal/billing/linked_billing.go
Show resolved
Hide resolved
generated-usage-examples/go/atlas-sdk-go/project-copy/internal/fileutils/io.go
Outdated
Show resolved
Hide resolved
dacharyc
left a comment
dacharyc
left a comment
There was a problem hiding this comment.
I think if we want to change the logic of the line_items example, we need to do the refactor in a different place. Otherwise, everything here LGTM!
2 participants
Description
Add examples, functions, and related tests for the following billing functionality:
Project changes:
cmd>examplesexamples/monitoringLinked Jira tickets:
Related Tasks
docs repo tasks
artifact repo tasks
README.mdCHANGELOG.md