DOCSP-47923 Kubernetes for OIDC#640
Merged
lindseymoore merged 2 commits intomongodb:masterfrom Mar 10, 2025
Merged
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
requested changes
Feb 27, 2025
Contributor
mongoKart
left a comment
There was a problem hiding this comment.
Content looks good, but it should be moved to the OIDC section
katcharov
requested changes
Mar 7, 2025
Collaborator
Author
|
Thanks @katcharov, I added the MongoCredential section. Can you please verify whether a username is required for the createOidcCredential() method for Kubernetes? Is it ok to leave the method without any input rather than putting |
katcharov
reviewed
Mar 7, 2025
Collaborator
|
Looks like we have the following tests: Only (Password is not accepted for any OIDC.) |
katcharov
approved these changes
Mar 7, 2025
6387d01 to
9f17578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-47923
Staging Links
Self-Review Checklist