DOCSP-48687 - Standardize API Source Constants#666
Merged
mongoKart merged 3 commits intomongodb:masterfrom Mar 27, 2025
Merged
Conversation
✅ Deploy Preview for docs-java ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
reviewed
Mar 27, 2025
Comment on lines
33
to
35
| api-root = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs" | ||
| client-api = "{+api-root+}/mongodb-driver-sync/com/mongodb/client" | ||
| core-api = "{+api-root+}/mongodb-driver-core/com/mongodb" |
Contributor
There was a problem hiding this comment.
I think condensing these into just the following is sufficient.
Suggested change
| api-root = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs" | |
| client-api = "{+api-root+}/mongodb-driver-sync/com/mongodb/client" | |
| core-api = "{+api-root+}/mongodb-driver-core/com/mongodb" | |
| driver-api = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs/mongodb-driver-sync/com/mongodb" | |
| core-api = "https://mongodb.github.io/mongo-java-driver/{+version+}/apidocs/mongodb-driver-core/com/mongodb" |
Contributor
Author
There was a problem hiding this comment.
renamed to driver-api. kept other pieces after discussion
rustagir
approved these changes
Mar 27, 2025
Contributor
rustagir
left a comment
rustagir
left a comment
There was a problem hiding this comment.
The organization of the source constants lgtm thanks for the collaboration! Mainly checked to see if the API docs drawer was working as expected and selected a few random pages to test links.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
(cherry picked from commit 6f002e7)
mongoKart
added a commit
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48687
Staging Links
Self-Review Checklist