Skip to content

MONGOCRYPT-865 check resulting length of SecKeyCreateSignature #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinAlbs merged 1 commit into from
Feb 13, 2026
Merged

MONGOCRYPT-865 check resulting length of SecKeyCreateSignature #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kms-message/src/kms_crypto.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ kms_sha256_hmac (void *ctx,
size_t len,
unsigned char *hash_out);

#define KMS_SIGN_RSAES_PKCS1_V1_5_OUTLEN 256
/* signature_out must be a preallocated buffer of 256 bytes (or greater). */
bool
kms_sign_rsaes_pkcs1_v1_5 (void *sign_ctx,
Expand Down
3 changes: 3 additions & 0 deletions kms-message/src/kms_crypto_apple.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ kms_sign_rsaes_pkcs1_v1_5 (void *unused_ctx,
if (!signature_ref) {
goto cleanup;
}
if (CFDataGetLength(signature_ref) != KMS_SIGN_RSAES_PKCS1_V1_5_OUTLEN) {
goto cleanup;
}
memcpy (signature_out,
CFDataGetBytePtr (signature_ref),
(size_t) CFDataGetLength (signature_ref));
Expand Down
5 changes: 2 additions & 3 deletions kms-message/src/kms_gcp_request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
/* Set a default expiration of 5 minutes for JSON Web Tokens (GCP allows up to
* one hour) */
#define JWT_EXPIRATION_SECS 5 * 60
#define SIGNATURE_LEN 256

kms_request_t *
kms_gcp_request_oauth_new (const char *host,
Expand Down Expand Up @@ -87,7 +86,7 @@ kms_gcp_request_oauth_new (const char *host,
req->crypto.sign_ctx = opt->crypto.sign_ctx;
}

jwt_signature = calloc (1, SIGNATURE_LEN);
jwt_signature = calloc (1, KMS_SIGN_RSAES_PKCS1_V1_5_OUTLEN);
KMS_ASSERT (jwt_signature);
if (!req->crypto.sign_rsaes_pkcs1_v1_5 (
req->crypto.sign_ctx,
Expand All @@ -101,7 +100,7 @@ kms_gcp_request_oauth_new (const char *host,
}

jwt_signature_b64url =
kms_message_raw_to_b64url (jwt_signature, SIGNATURE_LEN);
kms_message_raw_to_b64url (jwt_signature, KMS_SIGN_RSAES_PKCS1_V1_5_OUTLEN);
if (!jwt_signature_b64url) {
KMS_ERROR (req, "Failed to base64url encode JWT signature");
goto done;
Expand Down