PYTHON-5231 Finish up test scripts and add documentation for creating a new test suite#2224
Merged
blink1073 merged 206 commits intomongodb:masterfrom Mar 25, 2025
Merged
PYTHON-5231 Finish up test scripts and add documentation for creating a new test suite#2224blink1073 merged 206 commits intomongodb:masterfrom
blink1073 merged 206 commits intomongodb:masterfrom
Conversation
Member
Author
|
I have no idea why there are so many merge commits. 😅 |
NoahStapp
requested changes
Mar 25, 2025
| def load_config_from_file(path: str | Path) -> dict[str, str]: | ||
| config = read_env(path) | ||
| for key, value in config.items(): | ||
| write_env(key, value) |
Contributor
There was a problem hiding this comment.
Does write_env() write the key-value pairs out to the runtime environment?
Member
Author
There was a problem hiding this comment.
It writes it to test-env.sh.
| SUB_TEST_REQUIRED = ["auth_aws", "auth_oidc", "kms", "mod_wsgi", "perf"] | ||
|
|
||
| EXTRA_TESTS = ["mod_wsgi", "aws_lambda", "search_index"] | ||
| EXTRA_TESTS = ["mod_wsgi", "aws_lambda"] |
Contributor
There was a problem hiding this comment.
Is search_index run somewhere else now?
Member
Author
There was a problem hiding this comment.
It is one of the test suites, not an extra test.
NoahStapp
approved these changes
Mar 25, 2025
Contributor
NoahStapp
left a comment
NoahStapp
left a comment
There was a problem hiding this comment.
Can you schedule an EG patch with every task and variant so we can check for hidden bugs/failures before merging?
Member
Author
Member
Author
|
I opened https://jira.mongodb.org/browse/PYTHON-5232 for the existing AWS Lambda failure. |
Member
Author
|
All set! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch build for affected tests: https://spruce.mongodb.com/version/67dee49075d954000779f542/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC