PYTHON-4924 - PoolClearedError should have TransientTransactionError …

[NoahStapp]

…label appended to it

[ShaneHarvey]

I don't think we need any pymongo changes here. We already add the error label to PoolClearedErrors here:

mongo-python-driver/pymongo/synchronous/mongo_client.py

Line 2607 in eea8a37

exc_val._add_error_label("TransientTransactionError")

[NoahStapp]

Would we expect the added test to still pass without the code changes then? It fails without these changes.

[ShaneHarvey]

That test should fail because we only add the TransientTransactionError if we're actually running a transaction.

[NoahStapp]

Got it, got it. We can go ahead and close this PR and ticket it sounds like then.

[ShaneHarvey]

Can you confirm that we have a test for "pool clear error" having the label in a txn? If not we should add one.

[NoahStapp]

Our Start Transactions Retry Example 1 section of TestTransactionExamples in test_examples.py refers to the label, but I don't think it is intended to fail every time and check for the label:

mongo-python-driver/test/asynchronous/test_examples.py

Lines 1007 to 1021 in 58a41ae

	async def run_transaction_with_retry(txn_func, session):
	while True:
	try:
	await txn_func(session) # performs transaction
	break
	except (ConnectionFailure, OperationFailure) as exc:
	print("Transaction aborted. Caught exception during transaction.")
	# If transient error, retry the whole transaction
	if exc.has_error_label("TransientTransactionError"):
	print("TransientTransactionError, retrying transaction ...")
	continue
	else:
	raise

[ShaneHarvey]

We still need that new tests added in this PR.

[ShaneHarvey]

We still need that new tests added in this PR.

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.