PYTHON-5288: SRV hostname validation fails when resolver and resolved hostnames are identical with three domain levels#2272
Merged
aclark4life merged 7 commits intomongodb:masterfrom Apr 9, 2025
aclark4life:PYTHON-5288
Merged
PYTHON-5288: SRV hostname validation fails when resolver and resolved hostnames are identical with three domain levels#2272aclark4life merged 7 commits intomongodb:masterfrom aclark4life:PYTHON-5288
aclark4life merged 7 commits intomongodb:masterfrom
aclark4life:PYTHON-5288
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
pymongo/synchronous/srv_resolver.py:140
- [nitpick] Consider assigning node[0].lower() to a variable (e.g., host) to improve readability and avoid repeated method calls.
if self.__fqdn == node[0].lower() and len(node[0].split(".")) < 3:
pymongo/asynchronous/srv_resolver.py:140
- [nitpick] Consider assigning node[0].lower() to a variable (e.g., host) to improve readability and avoid repeated method calls.
if self.__fqdn == node[0].lower() and len(node[0].split(".")) < 3:
ShaneHarvey
requested changes
Apr 9, 2025
Member
ShaneHarvey
left a comment
There was a problem hiding this comment.
Could you please update the PR title to be more descriptive (and include the jira ticket) and add a changelog entry?
ShaneHarvey
requested changes
Apr 9, 2025
ShaneHarvey
requested changes
Apr 9, 2025
Member
|
Looks good, let's add the changelog entry. |
ShaneHarvey
approved these changes
Apr 9, 2025
blink1073
pushed a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Apr 10, 2025
… hostnames are identical with three domain levels (mongodb#2272) (cherry picked from commit 86e221e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.